Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate params in pipelines #7930

Merged
merged 1 commit into from
May 16, 2024
Merged

Propagate params in pipelines #7930

merged 1 commit into from
May 16, 2024

Conversation

chitrangpatel
Copy link
Member

@chitrangpatel chitrangpatel commented May 6, 2024 •
edited

Prior to this, we allowed parameter propagation in an inlined pipelinerun. However, within a pipeline, we requrie a verbose spec. This was an oversight as indicated in #7901.
This PR fixes that issue by updating the validation logic in the webhook.

Fixes #7901.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Enable propagating params in Pipelines.

/kind bug

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2024
@chitrangpatel chitrangpatel added this to the Pipeline v0.60 milestone May 6, 2024
@JeromeJu JeromeJu self-assigned this May 7, 2024
@JeromeJu
Copy link
Member

JeromeJu commented May 7, 2024

Thanks for the release-note!
Shall we also add the changes to somewhere https://github.com/tektoncd/pipeline/blob/main/docs/pipelines.md#specifying-parameters?

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2024
@chitrangpatel chitrangpatel force-pushed the propagate-params-in-pipelines branch from aa47541 to fd78e36 Compare May 10, 2024 15:21
@chitrangpatel
Copy link
Member Author

Thanks for the release-note! Shall we also add the changes to somewhere https://github.com/tektoncd/pipeline/blob/main/docs/pipelines.md#specifying-parameters?

Done. PTAL again 🙏 Thanks!

@chitrangpatel chitrangpatel force-pushed the propagate-params-in-pipelines branch 2 times, most recently from ebd497d to e5d5c27 Compare May 13, 2024 15:48
@chitrangpatel
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@chitrangpatel
Copy link
Member Author

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel chitrangpatel force-pushed the propagate-params-in-pipelines branch from e5d5c27 to 21e510f Compare May 13, 2024 18:05
JeromeJu
JeromeJu approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@JeromeJu JeromeJu left a comment •
edited by chitrangpatel

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with the issue #7901 to be an extension of the capability of the existing API.

While this PR generally lgtm, shall we also update the TEP0107 to reflect so?

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@JeromeJu
Copy link
Member

JeromeJu commented May 14, 2024 •
edited by chitrangpatel

On second thought - do we need an integration test for this?

@chitrangpatel
Copy link
Member Author

chitrangpatel commented May 14, 2024 •
edited

On second thought - do we need an integration test for this?

I threw in an example test for this. If that's not ok, I can work on an integration test too. The trick is that it needs us to apply a pipeline separately on the cluster. The web hook was the one stopping its admission. I already added unit tests for that. The example test also allows us to test the web hook admission more easily. It also provides a nice example :)

The controller logic has not changed at all I think so the status and everything else remains the same. And that is already tested by the current e2e test for propagated params.

@chitrangpatel
Copy link
Member Author

I tend to agree with the issue #7901 to be an extension of the capability of the existing API.

While this PR generally lgtm, shall we also update the TEP0107 to reflect so?

Happy to do that!

@chitrangpatel
Copy link
Member Author

chitrangpatel commented May 15, 2024 •
edited

/hold

cc @afrittoli I put a hold so that we can all be on the same page here. Let's discuss it on the issue or in the API WG on Monday or offline.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@chitrangpatel
Copy link
Member Author

chitrangpatel commented May 16, 2024 •
edited

/hold cancel
Synced offline with @afrittoli! We are all on the same page now that this is an oversight and should be fixed.

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
afrittoli
afrittoli reviewed May 16, 2024
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!
Could you add a "negative" test to see that propagation on a referenced task is not allowed?

@chitrangpatel
Propagate params in pipelines
c43d14d 
Prior to this, we allowed parameter propagation in an inlined
pipelinerun. However, within a pipeline, we requrie a verbose spec.
This was an oversight as indicated in
tektoncd#7901.
This PR fixes that issue by updating the validation logic in the
webhook.

Fixes tektoncd#7901.

Propagate params in pipelines

Prior to this, we allowed parameter propagation in an inlined
pipelinerun. However, within a pipeline, we requrie a verbose spec.
This was an oversight as indicated in
tektoncd#7901.
This PR fixes that issue by updating the validation logic in the
webhook.

Fixes tektoncd#7901.
@chitrangpatel chitrangpatel force-pushed the propagate-params-in-pipelines branch from 21e510f to c43d14d Compare May 16, 2024 17:46
@chitrangpatel
Copy link
Member Author

Thanks, this looks good! Could you add a "negative" test to see that propagation on a referenced task is not allowed?

Done! PTAL!

afrittoli
afrittoli reviewed May 16, 2024
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@tekton-robot tekton-robot merged commit 1b74ff3 into tektoncd:main May 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@JeromeJu JeromeJu JeromeJu approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@afrittoli afrittoli

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipeline v0.60
Development

Successfully merging this pull request may close these issues.

Allow param and workspace propagation in Pipeline and Tasks
4 participants
@chitrangpatel @JeromeJu @tekton-robot @afrittoli