Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup auto config application for Prow #1

Closed
bobcatfish opened this issue Apr 23, 2019 · 5 comments · Fixed by #98
Closed

Setup auto config application for Prow #1

bobcatfish opened this issue Apr 23, 2019 · 5 comments · Fixed by #98
Assignees
@afrittoli @dibyom
Labels
area/prow Issues or PRs related to prow

Comments

@bobcatfish
Copy link
Contributor

Expected Behavior

When we make changes to our prow config:

  1. The pull request that proposes the changes should verify them as much as possible
  2. Once they are merged, they should be automatically applied to our prow cluster

Actual Behavior

  1. We have nothing verifying our config.yaml changes
  2. Once the changes are made, they must be applied manually with:
kubectl create configmap config --from-file=config.yaml=prow/config.yaml --dry-run -o yaml | kubectl replace configmap config -f -

Additional Info

Bonus: can we do this via a Task/Pipeline? See tektoncd/pipeline#267 for more info on our dogfood epic, will need zenhub access to see subtasks.
@bobcatfish bobcatfish mentioned this issue Apr 23, 2019
Closed
@vdemeester
Copy link
Member

/assign

@bobcatfish bobcatfish added this to the Pipelines 0.5 🐱 milestone May 28, 2019
@vdemeester vdemeester mentioned this issue Jun 12, 2019
Closed
10 tasks
@bobcatfish
Copy link
Contributor Author

We might be able to use https://github.com/kubernetes/test-infra/tree/master/prow/plugins/updateconfig

@vdemeester vdemeester added the area/prow Issues or PRs related to prow label Aug 7, 2019
@bobcatfish bobcatfish assigned dibyom and unassigned vdemeester Sep 10, 2019
@afrittoli
Copy link
Member

/assign

@afrittoli
Copy link
Member

afrittoli commented Oct 24, 2019 •
edited
Loading

Plan:

  • define a service account config-prow
  • define a secret in the dogfooding cluster that holds config-prow's token
  • define an event-listener / template / binding in the dogfooding cluster that uses config-prow credentials to update the config in the prow cluster

We can then use a k8s CronJob to trigger the event listener, and run the job e.g. hourly.
Once we have the event listener in place we might even hook it to a merge events in the plumbing repo. If there is concern with this plan, I'll go ahead and implement it in the next few days.

afrittoli referenced this issue in afrittoli/plumbing Oct 24, 2019
@afrittoli
WIP CD prow config using tekton
ffa2284 
Define an event listener that triggers a tekton task that deploys
prow configurations on a target k8s cluster / namespace from a
give git repo / path.

Closes #1
@afrittoli afrittoli mentioned this issue Oct 24, 2019
Merged
2 tasks
@afrittoli
Copy link
Member

afrittoli commented Oct 24, 2019 •
edited
Loading

Something along these lines: #98

afrittoli referenced this issue in afrittoli/plumbing Oct 26, 2019
@afrittoli
CD prow config using tekton
902ee88 
Define an event listener that triggers a tekton task that deploys
prow configurations on a target k8s cluster / namespace from a
give git repo / path.

Closes #1
afrittoli referenced this issue in afrittoli/plumbing Oct 26, 2019
@afrittoli
CD prow config using tekton
318c76a 
Define an event listener that triggers a tekton task that deploys
prow configurations on a target k8s cluster / namespace from a
give git repo / path.

Closes #1
afrittoli referenced this issue in afrittoli/plumbing Oct 26, 2019
@afrittoli
CD prow config using tekton
042c002 
Define an event listener that triggers a tekton task that deploys
prow configurations on a target k8s cluster / namespace from a
give git repo / path.

Closes #1
afrittoli referenced this issue in afrittoli/plumbing Oct 26, 2019
@afrittoli
CD prow config using tekton
0926fdc 
Define an event listener that triggers a tekton task that deploys
prow configurations on a target k8s cluster / namespace from a
give git repo / path.

Closes #1
afrittoli referenced this issue in afrittoli/plumbing Oct 26, 2019
@afrittoli
CD prow config using tekton
568f482 
Define an event listener that triggers a tekton task that deploys
prow configurations on a target k8s cluster / namespace from a
give git repo / path.

Closes #1
@afrittoli afrittoli mentioned this issue Oct 26, 2019
Closed
3 tasks
afrittoli referenced this issue in afrittoli/plumbing Oct 27, 2019
@afrittoli
CD prow config using tekton
ece0a3f 
Define an event listener that triggers a tekton task that deploys
prow configurations on a target k8s cluster / namespace from a
give git repo / path.

Closes #1
@bobcatfish bobcatfish removed this from the Pipelines 0.9 🐱 milestone Nov 25, 2019
@afrittoli afrittoli mentioned this issue Nov 27, 2019
Closed
tekton-robot pushed a commit that referenced this issue Jan 27, 2020
@afrittoli @tekton-robot
CD prow config using tekton
656a9bf 
Define an event listener that triggers a tekton task that deploys
prow configurations on a target k8s cluster / namespace from a
give git repo / path.

Move cronjobs into a cronjobs folder and add docs for each of them.

Closes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afrittoli afrittoli

@dibyom dibyom

Labels
area/prow Issues or PRs related to prow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CD prow config using tekton 🏗 afrittoli/plumbing
4 participants
@vdemeester @bobcatfish @afrittoli @dibyom