-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install golangci-lint from a release instead of master #125
Labels
area/test-infra
Issues or PRs related to the testing infrastructure
Comments
FYI the authors does not advise to use the I think we need a stable tag and not just a specific version that we need to (forget) update manually everytime, |
triggers needs Go 1.13, so we'll need to pin golangci-lint to >= v1.19.0 |
/assign |
chmouel
added a commit
to chmouel/tektoncd-plumbing
that referenced
this issue
Nov 28, 2019
We are doing some fancy python script to get the latest released binary from the github website and unpack it to /usr/local/bin Closes tektoncd#125 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
1 task
chmouel
added a commit
to chmouel/tektoncd-plumbing
that referenced
this issue
Nov 29, 2019
Let's install golangci-lint from a stable pinned version instead of master which can brings weird CI breakage. Closes tektoncd#125 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel
added a commit
to chmouel/tektoncd-plumbing
that referenced
this issue
Nov 29, 2019
Let's install golangci-lint from a stable pinned version instead of master which can brings weird CI breakage. Closes tektoncd#125 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel
added a commit
to chmouel/tektoncd-plumbing
that referenced
this issue
Nov 29, 2019
Let's install golangci-lint from a stable pinned version instead of master which can brings weird CI breakage. Closes tektoncd#125 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
tekton-robot
pushed a commit
that referenced
this issue
Nov 29, 2019
Let's install golangci-lint from a stable pinned version instead of master which can brings weird CI breakage. Closes #125 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When building the test-runner image, we are installing
golangci-lint
from master (usingRUN go get -u github.com/golangci/golangci-lint/cmd/golangci-lint
).We should install it from a release version instead to make sure its behavior doesn't change implicitly when bumping the test-runner image.
/cc @chmouel
Ref: tektoncd/pipeline#1634
/area test-infra
The text was updated successfully, but these errors were encountered: