Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install golangci-lint from a release instead of master #125

Closed
vdemeester opened this issue Nov 27, 2019 · 3 comments · Fixed by #129
Closed

Install golangci-lint from a release instead of master #125

vdemeester opened this issue Nov 27, 2019 · 3 comments · Fixed by #129
Assignees
@chmouel
Labels
area/test-infra Issues or PRs related to the testing infrastructure

Comments

@vdemeester
Copy link
Member

When building the test-runner image, we are installing golangci-lint from master (using RUN go get -u github.com/golangci/golangci-lint/cmd/golangci-lint).

We should install it from a release version instead to make sure its behavior doesn't change implicitly when bumping the test-runner image.

/cc @chmouel

Ref: tektoncd/pipeline#1634

/area test-infra
@tekton-robot tekton-robot added the area/test-infra Issues or PRs related to the testing infrastructure label Nov 27, 2019
@chmouel
Copy link
Member

chmouel commented Nov 27, 2019

FYI the authors does not advise to use the go get version https://github.com/golangci/golangci-lint#go-get (but we can maybe get away with that)

I think we need a stable tag and not just a specific version that we need to (forget) update manually everytime,

@wlynch
Copy link
Member

wlynch commented Nov 27, 2019

triggers needs Go 1.13, so we'll need to pin golangci-lint to >= v1.19.0

@wlynch wlynch mentioned this issue Nov 27, 2019
Closed
@chmouel
Copy link
Member

chmouel commented Nov 27, 2019

/assign

chmouel added a commit to chmouel/tektoncd-plumbing that referenced this issue Nov 28, 2019
@chmouel
Install golangci-lint and tkn with a stable binary release
1533a61 
We are doing some fancy python script to get the latest released binary from the
github website and unpack it to /usr/local/bin

Closes tektoncd#125

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel mentioned this issue Nov 28, 2019
Merged
1 task
chmouel added a commit to chmouel/tektoncd-plumbing that referenced this issue Nov 29, 2019
@chmouel
Install golangci-lint from a pinned version
608fbdc 
Let's install golangci-lint from a stable pinned version instead of master which
can brings weird CI breakage.

Closes tektoncd#125

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel added a commit to chmouel/tektoncd-plumbing that referenced this issue Nov 29, 2019
@chmouel
Install golangci-lint from a pinned version
2ad0325 
Let's install golangci-lint from a stable pinned version instead of master which
can brings weird CI breakage.

Closes tektoncd#125

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel added a commit to chmouel/tektoncd-plumbing that referenced this issue Nov 29, 2019
@chmouel
Install golangci-lint from a pinned version
d9c5759 
Let's install golangci-lint from a stable pinned version instead of master which
can brings weird CI breakage.

Closes tektoncd#125

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
tekton-robot pushed a commit that referenced this issue Nov 29, 2019
@chmouel @tekton-robot
Install golangci-lint from a pinned version
1e5c529 
Let's install golangci-lint from a stable pinned version instead of master which
can brings weird CI breakage.

Closes #125

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chmouel chmouel

Labels
area/test-infra Issues or PRs related to the testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install a pinned stable version of golangci-lint instead of master chmouel/tektoncd-plumbing
4 participants
@vdemeester @chmouel @wlynch @tekton-robot