Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embedded-status feature flag #1339

Merged

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Feb 3, 2023

Changes

This commit removes the embedded-status feature flag config for the dogfooding cluster
and the prow env setup.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 3, 2023
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 3, 2023
@JeromeJu JeromeJu force-pushed the tep100-pipelinerunstatus-migration branch from ac5e224 to 30c068b Compare February 3, 2023 19:42
@JeromeJu JeromeJu force-pushed the tep100-pipelinerunstatus-migration branch from 30c068b to 7347530 Compare February 3, 2023 19:43
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@lbernick
Copy link
Member

lbernick commented Feb 6, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@tekton-robot tekton-robot merged commit 21ca67c into tektoncd:main Feb 6, 2023
@afrittoli
Copy link
Member

Thanks @JeromeJu - I think we could have left the env variable in the prow job for a bit longer since it won't break newer releases but it will be needed when running the test against older branches (e.g. a new v0.41.x release or so).

A NIT on commit message, it would be helpful to indicate why changes are made and not only what changes are included in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants