Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added REST proxy over existing RPCs #200

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Added REST proxy over existing RPCs #200

merged 1 commit into from
Sep 22, 2022

Conversation

sayan-biswas
Copy link
Contributor

What?
Added REST proxy for the gRPC services.

Why?
These changes will allow UI developers to access results API over REST
Context #198

How?
gRPC gateway is used to generate the REST handlers and routing is done through google.api.http annotations in the service definition.

@tekton-robot tekton-robot requested review from dibyom and a user June 28, 2022 11:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 28, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 28, 2022
@tekton-robot
Copy link

Hi @sayan-biswas. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 28, 2022
@dibyom
Copy link
Member

dibyom commented Jul 26, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2022
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2022
@sayan-biswas
Copy link
Contributor Author

Rebased branch and resolved conflicts with PR #214

@sayan-biswas
Copy link
Contributor Author

/assign @dibyom

@dibyom
Copy link
Member

dibyom commented Aug 30, 2022

hi @sayan-biswas - thanks for assigning. Might take me a few days to get to this :)

adambkaplan
adambkaplan reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and suggestions, but overall looks okay.

I would love to have an e2e test, but so far the test suite only checks the annotations from the watcher. We should have black box tests against the apiserver. Captured this in #230

cmd/api/main.go Outdated Show resolved Hide resolved
cmd/api/main.go Show resolved Hide resolved
cmd/api/main.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2022
@sayan-biswas sayan-biswas requested review from adambkaplan and removed request for dibyom September 21, 2022 07:13
adambkaplan
adambkaplan reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Generally looks good - a suggestion on the TLS_OVERRIDE option. Once that is in, please squash commits so we can merge.

cmd/api/README.md Outdated Show resolved Hide resolved
cmd/api/main.go Outdated Show resolved Hide resolved
cmd/api/main.go Outdated Show resolved Hide resolved
env/config Outdated Show resolved Hide resolved
@adambkaplan
Copy link
Contributor

cc @dibyom @vdemeester

Unsure why Prow is not adding the approved label, since I am in the OWNERS file...

@dibyom
Copy link
Member

dibyom commented Sep 21, 2022

Unsure why Prow is not adding the approved label, since I am in the OWNERS file...

Hmm...this is odd

@dibyom
Copy link
Member

dibyom commented Sep 21, 2022

@adambkaplan tektoncd/community#828 should fix this

@sayan-biswas
Copy link
Contributor Author

/assign @adambkaplan

@vdemeester
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
adambkaplan
adambkaplan approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adambkaplan,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 8312bc9 into tektoncd:main Sep 22, 2022
@enarha
Copy link
Contributor

enarha commented Feb 27, 2023

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 27, 2023
@adambkaplan adambkaplan mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

Assignees

@adambkaplan adambkaplan

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sayan-biswas @tekton-robot @dibyom @adambkaplan @vdemeester @enarha