-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of API server through config file #214
Conversation
Hi @CathalOConnorRH. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
DB_USER string `mapstructure:"DB_USER"` | ||
DB_PASSWORD string `mapstructure:"DB_PASSWORD"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to allow DB credentials to be stored in plaintext? Will Viper also allow these to be set with env vars, and the other settings to be populated via the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's optional to have the password in the config file, if a config item is set as a env var, viper will use that over the config file version [1] AutomaticEnv.
A question for the maintainers (@dibyom, perhaps) - is it worth updating the |
Sounds good as long as we don't allow passwords over config maps |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind feature |
Prep work for TEP-0117 to allow future configuration options through config file.
This change allows for both config file options and env var options, where the env var will override the config file option if it is set.