Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterRole aggregation for default user-facing roles #487

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Add ClusterRole aggregation for default user-facing roles #487

merged 1 commit into from
Aug 22, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented May 30, 2023 •
edited
Loading

Add ClusterRole aggregation for admin, edit and view users. Refer: https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 30, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2023
khrm
khrm commented May 30, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 30, 2023
@khrm
Copy link
Contributor Author

khrm commented May 30, 2023

Fixes #486

@khrm khrm linked an issue May 30, 2023 that may be closed by this pull request
Auth failure for admin and edit roles users #486
Closed
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 30, 2023
@khrm
Copy link
Contributor Author

khrm commented Jun 1, 2023

/retest

@sayan-biswas
Copy link
Contributor

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
adambkaplan
adambkaplan reviewed Jun 16, 2023
View reviewed changes
config/base/default-clusterroles.yaml Outdated Show resolved Hide resolved
config/base/default-clusterroles.yaml Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2023
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 17, 2023
@khrm
Copy link
Contributor Author

khrm commented Aug 17, 2023

@enarha Let's merge this before the release.

khrm
khrm commented Aug 17, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-tekton-results-integration-tests

@khrm khrm added this to the v0.8.0 milestone Aug 17, 2023
@khrm
Copy link
Contributor Author

khrm commented Aug 18, 2023

/retest

@khrm khrm force-pushed the khrm-patch-1 branch 2 times, most recently from b20edc9 to 40aeddd Compare August 18, 2023 10:53
@khrm
Copy link
Contributor Author

khrm commented Aug 21, 2023

@enarha @adambkaplan Can you re-review this and give lgtm if OK?

@khrm
Copy link
Contributor Author

khrm commented Aug 21, 2023

Can you re-review this and give lgtm if it's alright, @adambkaplan @vdemeester ?

@enarha
Copy link
Contributor

enarha commented Aug 22, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@tekton-robot tekton-robot merged commit 37a0235 into main Aug 22, 2023
5 checks passed
@khrm khrm deleted the khrm-patch-1 branch August 23, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan left review comments

@enarha enarha enarha left review comments

@alan-ghelardi alan-ghelardi Awaiting requested review from alan-ghelardi

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@enarha enarha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Auth failure for admin and edit roles users
5 participants
@khrm @sayan-biswas @tekton-robot @enarha @adambkaplan