-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CodeQL Analysis #492
Fix CodeQL Analysis #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test pull-tekton-results-build-tests
|
This probably won't fix Codeql. From what I can see: We don't have spaces between bracket in cli. |
d21161e
to
796ccae
Compare
@khrm It looks like the GH actions have been disabled and I do not see the CodeQL analyses running anymore. I'll mark that PR as do-not-merge as it's not needed, but I'll keep it around few days in case e need to debug and fix CodeQL. |
/hold |
@enarha I removed that temporarily. Let's recheck. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CodeQL Analysis was recently enabled on Results, but it's failing with "fatal: not a git repository (or any of the parent directories): .git".
796ccae
to
5720fe9
Compare
@enarha: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
It looks like we have a competing PR: #494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have closed that PR. I opened it to check whether codeql started working but it still doesn't work.
I think we can safely close this because codeql-analysis was removed and it is still not working. |
Changes
CodeQL Analysis was recently enabled on Results, but it's failing with "fatal: not a git repository (or any of the parent directories): .git".
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes