Fix CodeQL Analysis

[enarha]

Changes

CodeQL Analysis was recently enabled on Results, but it's failing with "fatal: not a git repository (or any of the parent directories): .git".

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Tested your changes locally (if this is a code change)
• [ x] Follows the commit message standard
• [x ] Meets the Tekton contributor standards (including functionality, content, code)
• [ x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[khrm]

/lgtm
/approve

[khrm]

/test pull-tekton-results-build-tests

[khrm]

found .github/workflows/codeql-analysis.yml
.github/workflows/codeql-analysis.yml
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  5:16      error    too many spaces inside brackets  (brackets)
  5:21      error    too many spaces inside brackets  (brackets)
  8:16      error    too many spaces inside brackets  (brackets)
  8:21      error    too many spaces inside brackets  (brackets)
  24:20     error    too many spaces inside brackets  (brackets)
  24:25     error    too many spaces inside brackets  (brackets)
  52:6      warning  missing starting space in comment  (comments)

[khrm]

This probably won't fix Codeql. From what I can see:
https://github.com/tektoncd/cli/blob/main/.github/workflows/codeql-analysis.yml

We don't have spaces between bracket in cli.

[enarha]

@khrm It looks like the GH actions have been disabled and I do not see the CodeQL analyses running anymore. I'll mark that PR as do-not-merge as it's not needed, but I'll keep it around few days in case e need to debug and fix CodeQL.
/do-not-merge

[enarha]

/hold

[khrm]

@enarha I removed that temporarily. Let's recheck.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [khrm,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

@enarha: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[adambkaplan]

It looks like we have a competing PR: #494

[khrm]

I have closed that PR. I opened it to check whether codeql started working but it still doesn't work.

[khrm]

I think we can safely close this because codeql-analysis was removed and it is still not working.