Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recovery middleware to gRPC server #505

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Add recovery middleware to gRPC server #505

merged 1 commit into from
Jun 25, 2023

Conversation

sayan-biswas
Copy link
Contributor

@sayan-biswas sayan-biswas commented Jun 19, 2023 •
edited
Loading

Fixes #504

Changes

Add recovery middleware in the gRPC interceptor chain to prevent termination of the main go routine when server panics due to runtime errors.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

- api: Recovery middleware added to intercept server panics, recover and send Internal Server Error response instead of terminating the server.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jun 19, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2023
@sayan-biswas
Copy link
Contributor Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jun 19, 2023
@sayan-biswas
Copy link
Contributor Author

/test pull-tekton-results-integration-tests

adambkaplan
adambkaplan approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Code looks good.

@sayan-biswas can you please fill in a release note? This change is worth noting for those operating Tekton Results in production.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jun 20, 2023
@enarha
Copy link
Contributor

enarha commented Jun 22, 2023

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 22, 2023
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 24, 2023
@sayan-biswas
Copy link
Contributor Author

@enarha Rebased, need lgtm.

enarha
enarha reviewed Jun 25, 2023
View reviewed changes
cmd/api/main.go Outdated Show resolved Hide resolved
@sayan-biswas
Add recovery middleware to gRPC server
6ed9020 
Fixes tektoncd#504
Add recovery middleware in the gRPC interceptor chain to prevent termination of the main go routine.
@enarha
Copy link
Contributor

enarha commented Jun 25, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2023
@tekton-robot tekton-robot merged commit 3c15843 into tektoncd:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enarha enarha enarha left review comments

@adambkaplan adambkaplan adambkaplan approved these changes

@alan-ghelardi alan-ghelardi Awaiting requested review from alan-ghelardi

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@enarha enarha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle panics in API server
4 participants
@sayan-biswas @tekton-robot @enarha @adambkaplan