-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop NET_BIND_SERVICE cap as it isn't necessary #663
Conversation
/kind cleanup |
Hi @drGrove. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
NET_BIND_SERVICE is only necessary for applications the require access to privileged ports, eg. ports under 1024. Since we are using ports that any user may listen on, this is unnecessary
996d517
to
260aad3
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@drGrove thank you so much for catching this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While the SERVER_PORT is configurable and theoretically someone could set that to a port <1024, I think it's a good change. |
/kind misc |
Changes
NET_BIND_SERVICE is only necessary for applications the require access to privileged ports, eg. ports under 1024. Since we are using ports that any user may listen on, this is unnecessary
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes