-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timestamps to json log output of controller #800
Comments
Having the timestamp included in the logs definitely seems like a useful addition. In the meantime you can pass the
|
afrittoli
added a commit
to afrittoli/triggers
that referenced
this issue
Oct 15, 2020
The controller and webhook logs do not include timestamps, which makes troubleshooting issues much harder. Adding the timestamps into the default logging configuration. Fixes: tektoncd#800 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
tekton-robot
pushed a commit
that referenced
this issue
Oct 16, 2020
The controller and webhook logs do not include timestamps, which makes troubleshooting issues much harder. Adding the timestamps into the default logging configuration. Fixes: #800 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Thank you @afrittoli for the quick fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Easy to detect via logs how long it took from receiving the webhook HTTP request until is done creating resources and replying back to the webhook originator (ie github)
Actual Behavior
Sometimes github would complain that the request time out because the response from the trigger listener controller didn't reply in time.
This is based on my vague understanding
Steps to Reproduce the Problem
Additional Info
Using tekton triggers provided via stable channel on OpenShift Pipelines Operator
The text was updated successfully, but these errors were encountered: