Update examples for consistency #1140
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
/assign @savitaashture |
|
@dibyom: GitHub didn't allow me to request PR reviews from the following users: sm43. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
The ingress test had a few issues: 1. It was creating an EL with a service account that did not have all necessary roles. This meant the EL deployment would go into a CrashLoopBackoff. 2. We never checked to see if the Deployment was available. We simply waited to see if the EL service was available. This commit fixes these two issues by correcting the SA for the EL and by adding a command to wait for the EventListener to become Ready before proceeding. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
There are a few different updates to the examples folder in this PR.
examples/README.mddescribed a single example while there were also sub-folders containing other Triggers examples. I moved the example described inexamples/README.mdto its own folder to be consistent with the other examples (embedded-triggers)I modified
examples/README.mdwith a more generic Readme that now contains instructions on invoking triggers locally as well as how to look for the resources that Triggers creates (and logs in the EL when things go wrong).I also fixed the ingress e2e test that was being flaky.
Part of #1067
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes