Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enable/disable option to set events for EventListener in controller.yaml #1300

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Add enable/disable option to set events for EventListener in controller.yaml #1300

merged 1 commit into from
Feb 10, 2022

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Jan 31, 2022 •
edited by dibyom
Loading

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Triggers now support enabling or disabling of emitting EventListener events by modifying argument in controller.yaml

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 31, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 75.1% 74.6% -0.5

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 75.1% 74.6% -0.5

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 75.1% 74.6% -0.5

@savitaashture savitaashture mentioned this pull request Feb 4, 2022
Merged
4 tasks
@savitaashture savitaashture added this to the Triggers v0.19 milestone Feb 4, 2022
@savitaashture
Copy link
Contributor Author

@dibyom @khrm can i get review for this as this is planned for 0.19 release

@dibyom
Copy link
Member

dibyom commented Feb 4, 2022

yes!

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
dibyom
dibyom reviewed Feb 4, 2022
View reviewed changes
cmd/controller/main.go Outdated
image = flag.String("el-image", elresources.DefaultImage, "The container image for the EventListener Pod.")
port = flag.Int("el-port", elresources.DefaultPort, "The container port for the EventListener to listen on.")
setSecurityContext = flag.Bool("el-security-context", elresources.DefaultSetSecurityContext, "Add a security context to the event listener deployment.")
setEventListenerEvent = flag.Bool("el-events", elresources.DefaultEventListenerEvent, "Enable events for event listener deployment.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of making this flag a string instead of a bool? The values for now would be "enable" and "disable". We could, in the future, add values to selectively send only some events and not others.

Copy link
Contributor Author

@savitaashture savitaashture Feb 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure i can make it as string
naive q:

We could, in the future, add values to selectively send only some events and not others.

do you mean adding values to string variable ?
and what kind of values we will expect 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable, disable, only-success-events, all-events etc. things like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah i see 👍
Updated PR with string instead of bool
PTAL
Thank you

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 75.1% 74.6% -0.5

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 75.1% 74.6% -0.5

dibyom
dibyom reviewed Feb 8, 2022
View reviewed changes
docs/events.md Outdated
- name: tekton-triggers-controller
image: "ko://github.com/tektoncd/triggers/cmd/controller"
args: [
"-el-events=true",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated.

Copy link
Contributor Author

@savitaashture savitaashture Feb 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/sink.go 75.1% 74.6% -0.5

@dibyom
Copy link
Member

dibyom commented Feb 10, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@tekton-robot tekton-robot merged commit 5901732 into tektoncd:main Feb 10, 2022
@khrm khrm added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@khrm khrm Awaiting requested review from khrm

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@savitaashture @tekton-robot @dibyom @khrm