Add ability to send cloudevent during trigger processing #1259

khrm · 2021-11-08T11:07:33Z

Changes

Define targetURI field in EL spec to send cloud events during trigger processing. FeatureFlag should also be alpha.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices
Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Define `targetURI` field in EL spec to send cloud event during trigger processing. FeatureFlag in configmap should also be `alpha`.

tekton-robot · 2021-11-08T12:22:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/initialization.go	53.3%	50.0%	-3.3

tekton-robot · 2021-11-15T11:13:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	75.8%	21.4%	-54.4

tekton-robot · 2021-11-18T11:04:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	75.8%	75.1%	-0.6

tekton-robot · 2021-11-18T12:27:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	75.8%	75.1%	-0.6

khrm · 2021-11-18T12:47:10Z

/test pull-tekton-triggers-integration-tests

pkg/apis/triggers/v1beta1/event_listener_types.go

savitaashture · 2021-11-24T06:31:47Z

🎉 🎉

@khrm It would be great if you add doc on how to use cloudevents for EventListener

tekton-robot · 2022-02-16T18:05:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.9%	98.0%	0.1
pkg/sink/cloudevent/cloudevent.go	Do not exist	73.3%
pkg/sink/cloudevent/cloudeventclient.go	Do not exist	11.1%
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	74.6%	73.5%	-1.1

tekton-robot · 2022-02-17T07:29:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.9%	98.0%	0.1
pkg/sink/cloudevent/cloudevent.go	Do not exist	73.3%
pkg/sink/cloudevent/cloudeventclient.go	Do not exist	11.1%
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	74.6%	73.5%	-1.1

dibyom · 2022-02-18T22:33:08Z

/approve

Some housekeeping things - Could you update the PR description + add a release note?

tekton-robot · 2022-02-21T12:27:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.9%	98.0%	0.1
pkg/sink/cloudevent/cloudevent.go	Do not exist	73.3%
pkg/sink/cloudevent/cloudeventclient.go	Do not exist	11.1%
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	74.6%	73.5%	-1.1

savitaashture · 2022-02-22T15:38:42Z

pkg/sink/sink.go

@@ -376,6 +400,8 @@ func (r Sink) processTrigger(t triggersv1.Trigger, request *http.Request, event
 		return
 	}
 	go r.recordResourceCreation(resources)
+	r.sendCloudEvents(request.Header, *el, eventID, events.TriggerProcessingSuccessfulV1)


Are we planning to send events of processTrigger as well ?

/cc @dibyom

Asking this because with that line only success event will be sent do we plan to send failure events as well?
like

finalPayload, header, iresp, err := r.ExecuteTriggerInterceptors(t, request, event, log, eventID, extensions) if err != nil { log.Error(err) return }

so above when there is error we are not capturing event

Same applicable for K8s as well

TriggerProcessing errors aren't error most of the time. It's because of filters, etc. So we are sending only Successful Event if a trigger succeed.

Ah okok could you add this as well

r.emitEvents(r.EventRecorder, el, events.TriggerProcessingSuccessfulV1, nil)

which handles for K8s

tekton-robot · 2022-02-23T07:14:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.9%	98.0%	0.1
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	74.6%	73.6%	-1.0

Define `targetURI` field in EL spec to send cloud event during trigger processing. FeatureFlag should also be `alpha`.

tekton-robot · 2022-02-23T07:19:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.9%	98.0%	0.1
pkg/sink/cloudevent/cloudevent.go	Do not exist	73.3%
pkg/sink/cloudevent/cloudeventclient.go	Do not exist	11.1%
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	74.6%	73.6%	-1.0

khrm · 2022-02-23T07:34:18Z

/test pull-tekton-triggers-integration-tests

tekton-robot · 2022-02-23T08:11:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.9%	98.0%	0.1
pkg/sink/cloudevent/cloudevent.go	Do not exist	73.3%
pkg/sink/cloudevent/cloudeventclient.go	Do not exist	11.1%
pkg/sink/initialization.go	53.3%	50.0%	-3.3
pkg/sink/sink.go	74.6%	73.8%	-0.9

khrm · 2022-02-23T08:50:43Z

/test pull-tekton-triggers-integration-tests

savitaashture

/lgtm

Thank you 👍 🎉

tekton-robot · 2022-02-23T09:58:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dibyom,savitaashture]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 8, 2021

tekton-robot requested review from dibyom and wlynch November 8, 2021 11:07

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2021

khrm force-pushed the cloudEvent branch from 6aad5c0 to cbf17db Compare November 8, 2021 12:20

khrm force-pushed the cloudEvent branch from cbf17db to 07fc0f9 Compare November 15, 2021 11:11

khrm force-pushed the cloudEvent branch from 07fc0f9 to e0411b8 Compare November 16, 2021 09:42

khrm changed the title ~~WIP: Add ability to send cloudevent during trigger processing~~ Add ability to send cloudevent during trigger processing Nov 16, 2021

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2021

khrm force-pushed the cloudEvent branch 10 times, most recently from bd194a4 to ccf01b1 Compare November 18, 2021 11:02

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2021

khrm force-pushed the cloudEvent branch from ccf01b1 to 8c85020 Compare November 18, 2021 12:25

savitaashture reviewed Nov 24, 2021

View reviewed changes

pkg/apis/triggers/v1beta1/event_listener_types.go Outdated Show resolved Hide resolved

khrm force-pushed the cloudEvent branch from b402359 to 4fe0bcb Compare February 16, 2022 18:04

khrm force-pushed the cloudEvent branch from 4fe0bcb to b8b6768 Compare February 17, 2022 07:27

tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 18, 2022

khrm force-pushed the cloudEvent branch from b8b6768 to adecfc8 Compare February 21, 2022 12:26

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2022

savitaashture reviewed Feb 22, 2022

View reviewed changes

tekton-robot requested a review from dibyom February 22, 2022 15:38

khrm force-pushed the cloudEvent branch from adecfc8 to 0b72377 Compare February 23, 2022 07:12

Add ability to send cloudevent during trigger processing

195b00e

Define `targetURI` field in EL spec to send cloud event during trigger processing. FeatureFlag should also be `alpha`.

khrm force-pushed the cloudEvent branch from 0b72377 to 195b00e Compare February 23, 2022 07:18

Send k8s Successful Event when trigger processing create resource

d7f10c1

savitaashture reviewed Feb 23, 2022

View reviewed changes

tekton-robot assigned savitaashture Feb 23, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022

savitaashture approved these changes Feb 23, 2022

View reviewed changes

tekton-robot merged commit 301135a into tektoncd:main Feb 23, 2022

khrm added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 24, 2022

khrm mentioned this pull request May 12, 2022

CloudEvents for EventListener processing #1221

Closed

khrm deleted the cloudEvent branch February 28, 2023 04:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to send cloudevent during trigger processing #1259

Add ability to send cloudevent during trigger processing #1259

khrm commented Nov 8, 2021 •

edited

Loading

tekton-robot commented Nov 8, 2021

tekton-robot commented Nov 15, 2021

tekton-robot commented Nov 18, 2021

tekton-robot commented Nov 18, 2021

khrm commented Nov 18, 2021

savitaashture commented Nov 24, 2021 •

edited

Loading

tekton-robot commented Feb 16, 2022

tekton-robot commented Feb 17, 2022

dibyom commented Feb 18, 2022

tekton-robot commented Feb 21, 2022

savitaashture Feb 22, 2022 •

edited

Loading

khrm Feb 23, 2022

savitaashture Feb 23, 2022

khrm Feb 23, 2022

tekton-robot commented Feb 23, 2022

tekton-robot commented Feb 23, 2022

khrm commented Feb 23, 2022

tekton-robot commented Feb 23, 2022

khrm commented Feb 23, 2022

savitaashture left a comment

tekton-robot commented Feb 23, 2022

Add ability to send cloudevent during trigger processing #1259

Add ability to send cloudevent during trigger processing #1259

Conversation

khrm commented Nov 8, 2021 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Nov 8, 2021

tekton-robot commented Nov 15, 2021

tekton-robot commented Nov 18, 2021

tekton-robot commented Nov 18, 2021

khrm commented Nov 18, 2021

savitaashture commented Nov 24, 2021 • edited Loading

tekton-robot commented Feb 16, 2022

tekton-robot commented Feb 17, 2022

dibyom commented Feb 18, 2022

tekton-robot commented Feb 21, 2022

savitaashture Feb 22, 2022 • edited Loading

Choose a reason for hiding this comment

khrm Feb 23, 2022

Choose a reason for hiding this comment

savitaashture Feb 23, 2022

Choose a reason for hiding this comment

khrm Feb 23, 2022

Choose a reason for hiding this comment

tekton-robot commented Feb 23, 2022

tekton-robot commented Feb 23, 2022

khrm commented Feb 23, 2022

tekton-robot commented Feb 23, 2022

khrm commented Feb 23, 2022

savitaashture left a comment

Choose a reason for hiding this comment

tekton-robot commented Feb 23, 2022

khrm commented Nov 8, 2021 •

edited

Loading

savitaashture commented Nov 24, 2021 •

edited

Loading

savitaashture Feb 22, 2022 •

edited

Loading