header key, case-insensitive match #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
akihikokuroda
force-pushed
the
header
branch
from
24bbbc5
to
43db89a
Compare
tekton-robot
added
size/L
|
/test pull-tekton-triggers-build-tests |
ncskier
reviewed
Feb 27, 2020
There was a problem hiding this comment.
Please add a little documentation in the TriggerBinding.md saying that the header comparison is case-insensitive.
|
/test pull-tekton-triggers-build-tests |
akihikokuroda
force-pushed
the
header
branch
2 times, most recently
from
c8d287f
to
a1a3253
Compare
|
I added a statement and an example in the triggerbindings.md |
akihikokuroda
force-pushed
the
header
branch
from
a1a3253
to
cf12041
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncskier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This resolve #458
Issue:
The keys in the request header are converted by
CanonicalMIMEHeaderKeybefore they are passed to the event sink code. So the cases of the key string are not same as sent from the source. This causes failure of matching header key. Theheader.X-GitHub-Eventwas not found because it was converted toX-Github-Event.Change:
The header keys specified in the TriggerBinding are converted with the same function before it is searched in the headers.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes