-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional documentation. #475
Add additional documentation. #475
Conversation
/retest all |
/test pull-tekton-triggers-build-tests |
5144eb5
to
ffc2fc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! One request: Can we update the description of the CEL Interceptors section to say something like CEL Interceptors can be used to filter or modify incoming events.
And then have two sub-sections one for Overlays (like the one you added here) and one for Filters?
ffc2fc4
to
346c860
Compare
This is failing, but I can't really see why.
|
@bigkevmcd I've noticed some flakiness in our build tests especially when the commits contain markdown files :( |
/test pull-tekton-triggers-build-tests |
346c860
to
3269a96
Compare
/test pull-tekton-triggers-integration-tests |
This adds additional documentation for using the CEL interceptor's _overlays_ feature. Includes examples of before and after, and using the values from a binding.
3269a96
to
3e78c4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Adds additional documentation for the CEL interceptor.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes