Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sets.NewString instead of map[string]struct{} #663

Merged
merged 1 commit into from Jul 7, 2020
Merged

Use sets.NewString instead of map[string]struct{} #663

merged 1 commit into from Jul 7, 2020

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Jul 7, 2020 •
edited

Changes

Motivated by PR tektoncd/pipeline#2909 .
This pull request replaces the use of map[string]struct{} with sets.String from K8s apimachinery.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 7, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2020
@savitaashture savitaashture changed the title Use sets.NewString instead of map[string]struct{}{} Use sets.NewString instead of map[string]struct{} Jul 7, 2020
vdemeester
vdemeester reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@dibyom
Copy link
Member

dibyom commented Jul 7, 2020

Neat! Thanks!
/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@tekton-robot tekton-robot merged commit c90895f into tektoncd:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@ncskier ncskier Awaiting requested review from ncskier

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@savitaashture @dibyom @tekton-robot @vdemeester