-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle validation, defaults and working behavior for Replicas #751
Conversation
The following is the coverage report on the affected files.
|
Nice, thanks for fixing this. The only minor comment I have is that the PR description contains a lot of useful info. It would be nice to have that as part of the commit message too! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dibyom modified commit message |
/lgtm |
/retest |
WIP Fixes tektoncd#751 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
In tektoncd#712, we added a feature to propagate annotations added to the EL to its underlying resources. However, this resulted in infinite reconcile loops since the deployment controller will add a standard revision annotation that the EL controller will keep trying to overwrite. To fix this, this commit switches the annotation propagation to merge any annotations set on the underlying resources before adding any extra annotations from the EL. Fixes tektoncd#751 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
Changes
replicas
on deployment was not working eventhoughreplicas
not provided as part ofel.spec
.That means if user don't specify
replicas
as part ofel.spec
then the edit operation on deployment should be success(edit operation on deployments can be done manually or any other mechanism ex: HPA).as per the discussion from this PR #715 (comment)
Signed-off-by: Savita Ashture sashture@redhat.com
/cc @dibyom
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
replicas
as part of eventlistener specreplicas
set on eventlistener spec then user can do edit operation on deployment manually or by any other mechanism (ex: HPA)replicas
validation will fail and provide below error0
then a default value1
will be set by webhook