Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pipeline version v0.16.3 #765

Closed
wants to merge 1 commit into from

Conversation

savitaashture
Copy link
Contributor

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 22, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dibyom
You can assign the PR to them by writing /assign @dibyom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 22, 2020
@dibyom
Copy link
Member

dibyom commented Sep 22, 2020

I think this also changes the minimum version of k8s we need to 1.16 or higher

@savitaashture savitaashture force-pushed the v0.16.3-bump branch 2 times, most recently from 70ae05d to f5077de Compare September 23, 2020 12:38
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go 73.9% 68.0% -5.9

@tekton-robot
Copy link

@savitaashture: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-triggers-unit-tests 4a064a3 link /test tekton-triggers-unit-tests
pull-tekton-triggers-build-tests 4a064a3 link /test pull-tekton-triggers-build-tests
pull-tekton-triggers-integration-tests 4a064a3 link /test pull-tekton-triggers-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

1 similar comment
@tekton-robot
Copy link

@savitaashture: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-triggers-unit-tests 4a064a3 link /test tekton-triggers-unit-tests
pull-tekton-triggers-build-tests 4a064a3 link /test pull-tekton-triggers-build-tests
pull-tekton-triggers-integration-tests 4a064a3 link /test pull-tekton-triggers-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@savitaashture
Copy link
Contributor Author

I think this also changes the minimum version of k8s we need to 1.16 or higher

yes using v0.17.6 but i think because of knative pkg version change there is some changes in generated clients

@dibyom
Copy link
Member

dibyom commented Sep 23, 2020

I think this version also adds leader election capability so we might have to call Promote in any tests that create a reconciler:
https://github.com/tektoncd/pipeline/blob/master/pkg/reconciler/taskrun/taskrun_test.go#L294

@vdemeester
Copy link
Member

@tektoncd/triggers-maintainers so in the future, it would be nice if each triggers release would bump to the latest tektoncd/pipeline version available at that time 😛

@savitaashture
Copy link
Contributor Author

Raised another PR #767 and closing this because did lot of hacks and its becoming difficult to solve

/cc @dibyom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants