Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pipeline version to v0.16.3 #767

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Bump pipeline version to v0.16.3 #767

merged 1 commit into from
Sep 24, 2020

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Sep 23, 2020 •
edited
Loading

Changes

Bumped to pipeline version v0.16.3

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

The manual changes are:

  1. Call Promote in tests, otherwise our generated reconcilers won't do anything (they aren't the leader!)
  2. Fill namespaces in a few tests
The minimum Kubernetes supported version is now 1.16.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 23, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 23, 2020
This was referenced Sep 23, 2020
Closed
Closed
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go 73.9% 68.0% -5.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go 73.9% 68.0% -5.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go 73.9% 68.0% -5.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go 73.9% 76.9% 3.0
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go 77.6% 77.8% 0.2

@savitaashture
Copy link
Contributor Author

@dibyom PR is ready to review

dibyom
dibyom reviewed Sep 24, 2020
View reviewed changes
pkg/apis/triggers/v1alpha1/event_listener_types.go Outdated
}

// GetConditionSet retrieves the condition set for this resource. Implements
// the KRShaped interface.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Do we have to implement the KRShaped interface as part of this PR? I think this adds a new status.Condition of type Ready -- which is what we'd want but we'd also have to add logic for when Ready is true (e.g. when deployment/service are ready).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline seems to disable it for the existing types at the moment: https://github.com/tektoncd/pipeline/blob/master/pkg/apis/pipeline/v1beta1/pipelinerun_types.go#L41

Copy link
Contributor Author

@savitaashture savitaashture Sep 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes a new condition of type Ready needed

and i have handled here https://github.com/tektoncd/triggers/pull/767/files#diff-ac6d17e220f6c870c0bc0304bc7c53b4R115-R117

Copy link
Contributor Author

@savitaashture savitaashture Sep 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to do it same like pipeline we can disable it no issues

Let me know

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so if we are adding Ready we should ensure that it is only true iff both deployment and service are also ready. I think this will be a useful follow up. But since that's a feature and adds new fields to the type, we can add it in a follow up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya that make sense 👍

pkg/reconciler/v1alpha1/eventlistener/eventlistener_test.go Outdated Show resolved Hide resolved
pkg/reconciler/v1alpha1/eventlistener/eventlistener_test.go Outdated Show resolved Hide resolved
pkg/reconciler/v1alpha1/eventlistener/eventlistener_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go 73.9% 76.9% 3.0
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go 77.6% 77.8% 0.2

@dibyom
Copy link
Member

dibyom commented Sep 24, 2020

Thanks @savitaashture

Could we also update the Release Notes to mention the updated minimum version of k8s needed?

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Sep 24, 2020
@savitaashture
Copy link
Contributor Author

/retest

@savitaashture savitaashture force-pushed the v0.16.3-bump1 branch 2 times, most recently from e85b885 to 37fbc79 Compare September 24, 2020 17:22
@savitaashture
Copy link
Contributor Author

Thanks @savitaashture

Could we also update the Release Notes to mention the updated minimum version of k8s needed?

Updated Release Notes

@dibyom
Copy link
Member

dibyom commented Sep 24, 2020

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@dibyom
Copy link
Member

dibyom commented Sep 24, 2020

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 24, 2020
@tekton-robot tekton-robot merged commit c8123cf into tektoncd:master Sep 24, 2020
@dibyom
Copy link
Member

dibyom commented Sep 29, 2020

Not 100% sure, but we might also be running into tektoncd/pipeline#3237 with this change. Might be worth calling out in the release notes unless we get to upgrade again to a newer knative/pkg that has a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@khrm khrm Awaiting requested review from khrm

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@savitaashture @tekton-robot @dibyom