Add EventListener Selector For TriggerCRD #773

khrm · 2020-09-28T06:49:21Z

Changes

EventListener have NamespaceSelector field which gives us namespaces from where EventListener fetches Trigger object to process events.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes


Added Namespace Selector field for EventListener which enables EventListener to serve across the namespace. `namespaceSelector` field with `matchNames` need to be provided to enable selector.
`
  namespaceSelector:
    matchNames:
    - nsName1
    - nsName2
`

tekton-robot · 2020-09-28T07:28:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/sink.go	76.9%	81.4%	4.5
test/builder/eventlistener.go	81.9%	82.7%	0.7

tekton-robot · 2020-09-28T07:34:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/sink.go	76.9%	81.4%	4.5
test/builder/eventlistener.go	81.9%	82.7%	0.7

tekton-robot · 2020-09-28T08:44:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/sink.go	76.9%	81.4%	4.5
test/builder/eventlistener.go	78.7%	79.6%	0.9

tekton-robot · 2020-09-28T09:04:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/sink.go	76.9%	81.4%	4.5
test/builder/eventlistener.go	78.7%	79.6%	0.9

tekton-robot · 2020-09-28T09:13:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/sink.go	76.9%	81.4%	4.5
test/builder/eventlistener.go	78.7%	79.6%	0.9

tekton-robot · 2020-09-28T09:37:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/sink.go	76.9%	81.4%	4.5
test/builder/eventlistener.go	78.7%	79.6%	0.9

tekton-robot · 2020-09-28T09:43:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/sink.go	76.9%	81.2%	4.4
test/builder/eventlistener.go	78.7%	79.6%	0.9

tekton-robot · 2020-09-28T09:53:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/sink/sink.go	76.9%	75.0%	-1.9
test/builder/eventlistener.go	78.7%	79.6%	0.9

pkg/sink/sink.go

dibyom · 2020-10-06T14:59:08Z

pkg/apis/triggers/v1alpha1/event_listener_types.go

+// list of namespaces.
+// +k8s:openapi-gen=true
+type NamespaceSelector struct {
+	// Boolean describing whether all namespaces are selected in contrast to a


curious about this Any field. Wondering if we need a separate field or we could pass something to MatchNames to indicate we should select all namespaces (e.g. matchNames: ["*"] or matchNames:[""].

AdmissionWebhooks also have NameSpaceSelector (and ObjectSelector). We could take some pointers from there: https://github.com/kubernetes/api/blob/master/admissionregistration/v1beta1/types.go#L410

(might be worth seeing if there are any reusable bits in the implementation that we could use too)

Yes, any here could be dispense with but AdmissionWebhook implementation is for more complex scenarios. https://github.com/kubernetes/api/blob/8519c5ea46199d57724725d5b969c5e8e0533692/admissionregistration/v1beta1/types.go#L372

dibyom · 2020-10-06T15:06:09Z

pkg/sink/sink.go

-
+	var trItems []triggersv1.Trigger
+	if el.Spec.NamespaceSelector.Any {
+		trList, err := r.TriggersClient.TriggersV1alpha1().Triggers("").List(metav1.ListOptions{})


might want to use an informer here to reduce calls to the API server. ( can be a follow up though)

dibyom · 2020-10-06T15:08:21Z

@khrm was there additional work you were planning on doing before unmarking this as WIP?

(One thing we should add are some release notes and some docs/examples).

tekton-robot · 2020-11-05T18:44:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/builder/eventlistener.go	78.7%	79.6%	0.9

tekton-robot · 2020-11-10T06:37:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/builder/eventlistener.go	78.7%	79.6%	0.9

tekton-robot · 2020-11-19T12:47:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	100.0%	98.8%	-1.2
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	78.2%	78.5%	0.3
test/builder/eventlistener.go	78.7%	79.2%	0.4

tekton-robot · 2020-11-19T12:52:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	100.0%	98.8%	-1.2
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	78.2%	78.5%	0.3
test/builder/eventlistener.go	78.7%	79.2%	0.4

tekton-robot · 2020-11-19T13:15:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/triggerrun/cmd/root.go	45.7%	45.2%	-0.5
pkg/apis/triggers/v1alpha1/event_listener_validation.go	100.0%	98.8%	-1.2
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	78.2%	78.5%	0.3
test/builder/eventlistener.go	78.7%	79.2%	0.4

tekton-robot · 2020-11-19T13:37:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/triggerrun/cmd/root.go	45.7%	45.2%	-0.5
pkg/apis/triggers/v1alpha1/event_listener_validation.go	100.0%	98.8%	-1.2
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	78.2%	78.5%	0.3
test/builder/eventlistener.go	78.7%	79.2%	0.4

tekton-robot · 2020-11-19T13:51:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/triggerrun/cmd/root.go	45.7%	45.2%	-0.5
pkg/apis/triggers/v1alpha1/event_listener_validation.go	100.0%	98.8%	-1.2
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	78.2%	78.5%	0.3
pkg/sink/sink.go	83.9%	78.9%	-5.0
test/builder/eventlistener.go	78.7%	79.2%	0.4

tekton-robot · 2020-11-19T14:16:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/triggerrun/cmd/root.go	45.7%	45.2%	-0.5
pkg/apis/triggers/v1alpha1/event_listener_validation.go	100.0%	98.8%	-1.2
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	78.2%	78.5%	0.3
pkg/sink/sink.go	83.9%	78.9%	-5.0
test/builder/eventlistener.go	78.7%	79.2%	0.4

savitaashture · 2020-11-19T17:13:17Z

Code looks good to me 👍
@khrm can we add e2e to use trigger with NSSelector?

examples/selectors/03_trigger.yaml

examples/selectors/02_eventlistener-sel.yaml

pkg/sink/sink_test.go

tekton-robot · 2020-11-20T08:37:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/triggerrun/cmd/root.go	45.7%	45.2%	-0.5
pkg/apis/triggers/v1alpha1/event_listener_validation.go	100.0%	98.8%	-1.2
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	78.2%	78.5%	0.3
pkg/sink/sink.go	83.9%	78.9%	-5.0
test/builder/eventlistener.go	78.7%	79.2%	0.4

khrm · 2020-11-20T08:46:12Z

@savitaashture I would create another pr for e2e test after this is merge.

EventListener have NamespaceSelector field which gives us namespaces from where EventListener fetches Trigger object to process events.

tekton-robot · 2020-11-20T11:13:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/triggerrun/cmd/root.go	45.7%	45.2%	-0.5
pkg/apis/triggers/v1alpha1/event_listener_validation.go	100.0%	98.8%	-1.2
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	78.2%	78.5%	0.3
pkg/sink/sink.go	83.9%	78.9%	-5.0
test/builder/eventlistener.go	78.7%	79.2%	0.4

savitaashture

/lgtm

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 28, 2020

tekton-robot requested review from dlorenc and iancoffey September 28, 2020 06:49

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2020

khrm force-pushed the elSel branch from b71cc04 to 0373966 Compare September 28, 2020 07:33

khrm force-pushed the elSel branch from 0373966 to 64a3caa Compare September 28, 2020 08:43

khrm force-pushed the elSel branch from 64a3caa to 6f9cbcc Compare September 28, 2020 09:02

khrm force-pushed the elSel branch from 6f9cbcc to ae370ae Compare September 28, 2020 09:11

khrm force-pushed the elSel branch from ae370ae to da07c78 Compare September 28, 2020 09:35

khrm force-pushed the elSel branch from da07c78 to f280b81 Compare September 28, 2020 09:42

khrm force-pushed the elSel branch from f280b81 to 260a928 Compare September 28, 2020 09:51

khrm added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 28, 2020

dibyom linked an issue Sep 28, 2020 that may be closed by this pull request

EventListener Namespace Selector for Trigger Object #774

Closed

dibyom reviewed Oct 6, 2020

View reviewed changes

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2020

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2020

khrm force-pushed the elSel branch from c5577a1 to 6726403 Compare November 19, 2020 12:46

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2020

khrm force-pushed the elSel branch from 6726403 to aa72fad Compare November 19, 2020 12:51

khrm force-pushed the elSel branch from aa72fad to c589623 Compare November 19, 2020 13:14

khrm force-pushed the elSel branch from c589623 to ad6c2ea Compare November 19, 2020 13:36

khrm force-pushed the elSel branch from ad6c2ea to fe45ba2 Compare November 19, 2020 13:50

khrm force-pushed the elSel branch from fe45ba2 to 7a25d6c Compare November 19, 2020 14:15

savitaashture reviewed Nov 19, 2020

View reviewed changes

examples/selectors/03_trigger.yaml Show resolved Hide resolved

examples/selectors/02_eventlistener-sel.yaml Show resolved Hide resolved

pkg/sink/sink_test.go Outdated Show resolved Hide resolved

khrm force-pushed the elSel branch from 7a25d6c to d45827d Compare November 20, 2020 05:51

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2020

khrm force-pushed the elSel branch 2 times, most recently from 005adb7 to 837e2f5 Compare November 20, 2020 08:36

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2020

Add EventListener Selector For TriggerCRD

199e11f

EventListener have NamespaceSelector field which gives us namespaces from where EventListener fetches Trigger object to process events.

khrm force-pushed the elSel branch from 837e2f5 to 199e11f Compare November 20, 2020 11:12

savitaashture reviewed Nov 20, 2020

View reviewed changes

tekton-robot assigned savitaashture Nov 20, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020

tekton-robot merged commit 7702dc4 into tektoncd:master Nov 20, 2020

khrm deleted the elSel branch July 28, 2021 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EventListener Selector For TriggerCRD #773

Add EventListener Selector For TriggerCRD #773

khrm commented Sep 28, 2020 •

edited

Loading

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

dibyom Oct 6, 2020

dibyom Oct 23, 2020

khrm Nov 10, 2020

dibyom Oct 6, 2020

dibyom commented Oct 6, 2020

tekton-robot commented Nov 5, 2020

tekton-robot commented Nov 10, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

savitaashture commented Nov 19, 2020 •

edited

Loading

tekton-robot commented Nov 20, 2020

khrm commented Nov 20, 2020 •

edited

Loading

tekton-robot commented Nov 20, 2020

savitaashture left a comment

Add EventListener Selector For TriggerCRD #773

Add EventListener Selector For TriggerCRD #773

Conversation

khrm commented Sep 28, 2020 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

tekton-robot commented Sep 28, 2020

dibyom Oct 6, 2020

Choose a reason for hiding this comment

dibyom Oct 23, 2020

Choose a reason for hiding this comment

khrm Nov 10, 2020

Choose a reason for hiding this comment

dibyom Oct 6, 2020

Choose a reason for hiding this comment

dibyom commented Oct 6, 2020

tekton-robot commented Nov 5, 2020

tekton-robot commented Nov 10, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

tekton-robot commented Nov 19, 2020

savitaashture commented Nov 19, 2020 • edited Loading

tekton-robot commented Nov 20, 2020

khrm commented Nov 20, 2020 • edited Loading

tekton-robot commented Nov 20, 2020

savitaashture left a comment

Choose a reason for hiding this comment

khrm commented Sep 28, 2020 •

edited

Loading

savitaashture commented Nov 19, 2020 •

edited

Loading

khrm commented Nov 20, 2020 •

edited

Loading