Fix example SA permissions #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XL
|
@khrm We might want to do a patch release with this (or at least update the Release notes to point to this correct role resource. |
The service account used for examples had permissions for all namespaced Triggers resources but not `clustertriggerbindings`. With the switch to using listers instead of making direct API calls this means that the EL will keep printing out error log messages about not being able to fetch clustertriggerbindings. To fix this, I added updated the SA with the right ClusterRole and Binding. In addition, some of the examples were using their own roles/SAs/bindings. Instead of updating those, I created a single `rbac.yaml` file and added symlinks to it from the examples. Fixes tektoncd#846 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The service account used for examples had permissions for all namespaced
Triggers resources but not
clustertriggerbindings. With the switch to usinglisters instead of making direct API calls this means that the EL will keep
printing out error log messages about not being able to fetch
clustertriggerbindings. To fix this, I added updated the SA with the right
ClusterRole and Binding.
In addition, some of the examples were using their own roles/SAs/bindings.
Instead of updating those, I created a single
rbac.yamlfile and addedsymlinks to it from the examples.
Fixes #846
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes