Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s dependency bump #934

Merged
merged 1 commit into from
Feb 3, 2021
Merged

K8s dependency bump #934

merged 1 commit into from
Feb 3, 2021

Conversation

dprotaso
Copy link
Contributor

  • bumps k8s deps to v0.19.7
  • drops the require block from the k8s deps
    • these should just be inherited from knative.dev/pkg and github.com/tektoncd/pipeline.

After running codegen I noticed a test failing and it seems like the order of something was changed - unsure why see: 5e393f2

/kind cleanup

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 28, 2021
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 28, 2021
@tekton-robot
Copy link

Hi @dprotaso. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 28, 2021
MarcelMue
MarcelMue reviewed Jan 28, 2021
View reviewed changes
go.mod Outdated
@@ -12,7 +12,7 @@ require (
github.com/google/uuid v1.2.0
github.com/gorilla/mux v1.7.4
github.com/spf13/cobra v1.0.0
github.com/tektoncd/pipeline v0.20.0
github.com/tektoncd/pipeline v0.20.1-0.20210128163741-1eca890e74c9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this an untagged version of pipeline?

Copy link
Contributor Author

@dprotaso dprotaso Jan 28, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped it to the latest so we'd get the proper k8s version in the require block

tektoncd/pipeline#3724

go.sum Outdated Show resolved Hide resolved
@dibyom
Copy link
Member

dibyom commented Jan 28, 2021

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2021
@dprotaso
Copy link
Contributor Author

/assign @dibyom

dibyom
dibyom reviewed Jan 28, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dprotaso

One question: Does the bump the min version of k8s required to install Triggers to v1.19?

hack/update-deps.sh Show resolved Hide resolved
pkg/reconciler/v1alpha1/eventlistener/eventlistener_test.go
EventListeners: []*v1alpha1.EventListener{makeEL(), makeEL(withFinalizer, withDeletionTimestamp, func(el *v1alpha1.EventListener) {
el.Name = "el-2" // TODO: makeEL take name, ns as args
})},
EventListeners: []*v1alpha1.EventListener{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very odd indeed....Do the tests fail if we revert changes to this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@dprotaso
Copy link
Contributor Author

One question: Does the bump the min version of k8s required to install Triggers to v1.19?

No K8s policy supports N, N-1 - so the min version would be K8s 1.18

That's the next target for Knative & knative.dev/pkg

@dibyom
Copy link
Member

dibyom commented Jan 29, 2021

No K8s policy supports N, N-1 - so the min version would be K8s 1.18

Ah ok, so the min version of k8s needed right now is v1.17 https://github.com/tektoncd/triggers/blob/master/docs/install.md#pre-requisites

mind updating that page and squashing up the commits? Otherwise good to go!

@dprotaso dprotaso mentioned this pull request Jan 30, 2021
Merged
@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 3, 2021

Squashed & doc updated. I fixed upstream so there shouldn't be any dep pointing to k8s 1.18 modules

MarcelMue
MarcelMue approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, MarcelMue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@tekton-robot tekton-robot merged commit 6654c3d into tektoncd:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@MarcelMue MarcelMue MarcelMue approved these changes

@ncskier ncskier Awaiting requested review from ncskier

Assignees

@dibyom dibyom

@MarcelMue MarcelMue

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dprotaso @tekton-robot @dibyom @MarcelMue