-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s dependency bump #934
K8s dependency bump #934
Conversation
Hi @dprotaso. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
go.mod
Outdated
@@ -12,7 +12,7 @@ require ( | |||
github.com/google/uuid v1.2.0 | |||
github.com/gorilla/mux v1.7.4 | |||
github.com/spf13/cobra v1.0.0 | |||
github.com/tektoncd/pipeline v0.20.0 | |||
github.com/tektoncd/pipeline v0.20.1-0.20210128163741-1eca890e74c9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this an untagged version of pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped it to the latest so we'd get the proper k8s version in the require
block
/ok-to-test |
/assign @dibyom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dprotaso
One question: Does the bump the min version of k8s required to install Triggers to v1.19?
EventListeners: []*v1alpha1.EventListener{makeEL(), makeEL(withFinalizer, withDeletionTimestamp, func(el *v1alpha1.EventListener) { | ||
el.Name = "el-2" // TODO: makeEL take name, ns as args | ||
})}, | ||
EventListeners: []*v1alpha1.EventListener{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very odd indeed....Do the tests fail if we revert changes to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
No K8s policy supports N, N-1 - so the min version would be K8s 1.18 That's the next target for Knative & |
Ah ok, so the min version of k8s needed right now is v1.17 https://github.com/tektoncd/triggers/blob/master/docs/install.md#pre-requisites mind updating that page and squashing up the commits? Otherwise good to go! |
Squashed & doc updated. I fixed upstream so there shouldn't be any dep pointing to k8s 1.18 modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, MarcelMue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
require
block from the k8s depsknative.dev/pkg
andgithub.com/tektoncd/pipeline
.After running codegen I noticed a test failing and it seems like the order of something was changed - unsure why see: 5e393f2
/kind cleanup