getting-started: create webhook ExternalName vs GitHubDomain

[HerrmannHinz]

small fix in getting started doc

[tekton-robot]

@HerrmannHinz: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign savitaashture
You can assign the PR to them by writing /assign @savitaashture in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Tobias Herrmann Hinz (4abbe48)

[tekton-robot]

Hi @HerrmannHinz. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dibyom]

/ok-to-test

[tekton-robot]

@HerrmannHinz: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-triggers-build-tests	c24e1c5	link	/test pull-tekton-triggers-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tekton-robot]

@HerrmannHinz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[bobcatfish]

Thanks for the doc update @HerrmannHinz and apologies for the review coming SO FAR after the PR was opened 🙏

[bobcatfish]

hmm it seems like these are both important to the way the task works, but do different jobs - ExternalDomain is required, so im not sure it makes sense to completely remove it from these docs (https://github.com/tektoncd/triggers/blob/a545f76e7f0021ee13a1c22b6703dae18d2639fa/docs/getting-started/create-webhook.yaml)

if anything we probably want to add a bullet for GitHubDomain - explaining that you may need to override it if you're using github enterprise

[bobcatfish]

im not sure we want to add this by default here - maybe we could have it commented out? e.g.

#  If you are using github enterprise, uncomment this line <more context here>
#  - name: GitHubDomain
#    value: git.corp.com

[bobcatfish]

Apologies again for taking so long to review this @HerrmannHinz - if it's easier I've opened #1151 with the changes I requested here and I'll close this PR for now since it needs a rebase - but if you want to pick this up again plz feel free to re-open this PR or make a new one and I'm happy to close mine. Thanks again!