Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum.toString to equals compare #2312

Merged
merged 3 commits into from
Oct 10, 2023
Merged

enum.toString to equals compare #2312

merged 3 commits into from
Oct 10, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Oct 10, 2023 •
edited

fix for #2311

@AlvaroVega AlvaroVega marked this pull request as ready for review October 10, 2023 09:31
@danielvillalbamota
Copy link
Collaborator

This fix works, but to get better traces in the requests could we add the "body" information in this line?

fiware-cygnus/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/restutils/RestApi.java

Line 179 in bd11469

LOGGER.debug("requesting HTTP: " + strUrl);

Something like

LOGGER.debug("requesting HTTP: " + strUrl + "---BODY: " + body)

@danielvillalbamota danielvillalbamota mentioned this pull request Oct 10, 2023
Closed
danielvillalbamota
danielvillalbamota approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@danielvillalbamota danielvillalbamota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielvillalbamota danielvillalbamota merged commit 9d18551 into master Oct 10, 2023
6 checks passed
@danielvillalbamota danielvillalbamota deleted the fix/compare_gis_attribute_type_enum branch October 10, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvillalbamota danielvillalbamota danielvillalbamota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlvaroVega @danielvillalbamota