Bug #1289 #1441
Bug #1289 #1441
Conversation
| @@ -34,6 +34,12 @@ | |||
| #include "serviceRoutines/postUpdateContext.h" | |||
|
|
|||
|
|
|||
| static bool legalEntityLength(Entity* eP, const std::string &servicePath) | |||
| { | |||
| const int constant = 10; | |||
There was a problem hiding this comment.
I'd suggest to use a #define in the file preamble (i.e. just after the #include lines):
#define STRUCTURAL_OVERHEAD_BSON_ID 10
(The name is to align with the terms used by MongoDB documentation... "contant" is too broad)
There was a problem hiding this comment.
But for modern C and C++ the recommendation is use constants instead of #define maybe create a global file scoped constant? something like:
statict const int STRUCTURAL_OVERHEAD_BSON_ID = 10;
There was a problem hiding this comment.
#define (the one that we typically use in CB) has the advantage of pre-processor text replacement (i.e. faster code... although maybe marginally faster) while static const has the advantage of allowing semantics in the constant (so it is treated as int in every place were it is used).
Both are ok, not an important issue at this point (use the one you prefer).
There was a problem hiding this comment.
Fixed in 618422ee731b3896bd061782e740afb6dbb76de3
|
LGTM |
|
LGTM, but must be merged with develop before we can merge |
Fixes #1289