Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AGPL disclaimer #3441

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Add AGPL disclaimer #3441

merged 1 commit into from
Feb 20, 2019

Conversation

jason-fox
Copy link
Contributor

  • As requested by TSC.

* As requested by TSC.
For the avoidance of doubt, the owners of this software licensed under an AGPL-3.0 license
wish to make a clarifying public statement as follows:

> Please note that software derived as a result of modifying the source code of this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same text we have in the old catalogue, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - more specifically this the text from the TSC minutes from this morning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. However, I think the text should be moved up, so the copyright mark "© 2019 Telefonica Investigación y Desarrollo, S.A.U" ends at the end of the README.md file.

Copy link
Contributor Author

@jason-fox jason-fox Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satisfying all conflicting requirements within the limitations of a README is tricky.

screenshot 2019-02-19 at 10 12 51

The idea of keeping the copyright with the License section it is obvious that the copyright refers to the license - i.e. Telefonica holds the copyright and licenses under APGL. In an ideal world we wouldn't need the final disclaimer. The meaning of derivative work should be clear and there should be no problem just using copyleft software in a rights reserved project.

If you move the copyright below the disclaimer it appears to imply the following This software is licensed under AGPL, the copyright of the disclaimer held by Telefonica

Yes, ideally common practice states license at the bottom, copyright last line. It is typically just a couple of lines and doesn't have any extra text. However adding the disclaimer is an old requirement and since this week's TSC agreement was that the disclaimer must be placed prominently in the README I see leaving copyright above the disclaimer as less likely to cause confusion than moving it below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

NTC

Copy link
Member

@mrutid mrutid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrutid mrutid merged commit f996ec5 into telefonicaid:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants