Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add nock to test without context broker #81 #83

Merged

Conversation

vraybaud
Copy link
Contributor

No description provided.

Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a minor comment: please @vraybaud add a new entry in ChangeNextRelease file
LGTM

@fgalan
Copy link
Member

fgalan commented Jul 29, 2020

Thanks for your contribution!

In addition to @AlvaroVega comment about including and entry at CHANGES_NEXT_RELEASE about the change:

@fgalan fgalan mentioned this pull request Jul 29, 2020
@bobeal
Copy link
Contributor

bobeal commented Jul 29, 2020

Hi,

I've updated the PR with the following modifications:

  • Rebase on master
  • Add a note in CHANGES_NEXT_RELEASE
  • Remove lines related to Orion in .travis.yml

The Travis build fails for the "Documentation tests" stage, when running npm run lint:text. I'm investigating, but if you have an idea?

Coveralls also fails ... but about files that don't have changed in the PR. So I'm a bit clueless about this ...

@fgalan
Copy link
Member

fgalan commented Jul 29, 2020

With regards to lint fail, seems to be similar to telefonicaid/iotagent-json#483. No idea about this or about the coverage issue... maybe @jason-fox knows about this.

…oker telefonicaid#81

Signed-off-by: Benoit Orihuela <benoit.orihuela@eglobalmark.com>
@bobeal
Copy link
Contributor

bobeal commented Sep 10, 2020

Just rebased it on top of master (hence the force push).

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 4981678 into telefonicaid:master Sep 10, 2020
@fgalan
Copy link
Member

fgalan commented Sep 10, 2020

IOTA LWM2M seems to have a similar problem with the CB dependency (see https://github.com/telefonicaid/lightweightm2m-iotagent/blob/master/.travis.yml#L39 for intance).

@bobeal @vraybaud it would be great if you could use the expertise in this PR to do a similar "nock-erization" in that repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants