-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add nock to test without context broker #81 #83
feature: add nock to test without context broker #81 #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a minor comment: please @vraybaud add a new entry in ChangeNextRelease file
LGTM
Thanks for your contribution! In addition to @AlvaroVega comment about including and entry at CHANGES_NEXT_RELEASE about the change:
|
2d123e4
to
75a0b09
Compare
Hi, I've updated the PR with the following modifications:
The Travis build fails for the "Documentation tests" stage, when running Coveralls also fails ... but about files that don't have changed in the PR. So I'm a bit clueless about this ... |
With regards to lint fail, seems to be similar to telefonicaid/iotagent-json#483. No idea about this or about the coverage issue... maybe @jason-fox knows about this. |
64cc20e
to
044fcd6
Compare
…oker telefonicaid#81 Signed-off-by: Benoit Orihuela <benoit.orihuela@eglobalmark.com>
044fcd6
to
d9e7cd3
Compare
Just rebased it on top of master (hence the force push). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IOTA LWM2M seems to have a similar problem with the CB dependency (see https://github.com/telefonicaid/lightweightm2m-iotagent/blob/master/.travis.yml#L39 for intance). @bobeal @vraybaud it would be great if you could use the expertise in this PR to do a similar "nock-erization" in that repo :) |
No description provided.