Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add configuration for resource requests and limits, remove kubernetes manifest #67

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

szEvEz
Copy link
Collaborator

@szEvEz szEvEz commented Apr 2, 2024

  • The resource configuration moved out, due to usage of the helmify command - I have also not found a way to configure it the way we need it
  • removing manifests in deploy/ so we do not need to maintain two sets of config - we could think about automating it

From my point of view there is also no real benefit of storing the deploy manifests in the repo, if there is manual configuration required (adapting url and secret). If we could get around that, I'd love to generate a "deployment.yaml" and attach it to the release, like cert-manager does it for instance.

…tes manifest

- The resource configuration moved out, due to usage of the helmify
  command - I have also not found a way to configure it the way we need
it
- removing manifests in deploy/ so we do not need to maintain two sets
  of config - we could think about automating it
@szEvEz szEvEz requested a review from rndmh3ro as a code owner April 2, 2024 11:11
@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Apr 2, 2024

removing manifests in deploy/ so we do not need to maintain two sets of config - we could think about automating it

Well, it was automated. :)

@szEvEz
Copy link
Collaborator Author

szEvEz commented Apr 2, 2024

removing manifests in deploy/ so we do not need to maintain two sets of config - we could think about automating it

Well, it was automated. :)

But generating the helm chart from the deployment manifests using helmify is currently dropping configuration. How do we want to proceed here?

@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Apr 2, 2024

removing manifests in deploy/ so we do not need to maintain two sets of config - we could think about automating it

Well, it was automated. :)

But generating the helm chart from the deployment manifests using helmify is currently dropping configuration. How do we want to proceed here?

I'd be fine with generating the deploy-files from the helm-charts or modifying helmify so it does not drop the configuration.

NB: not everybody uses (or likes) helm and I want to support that. Removing the static files would also be a breaking change.

@rndmh3ro
Copy link
Collaborator

Hm, you completely removed the documentation on how to use it without helm. Can you re-add this please?

@szEvEz
Copy link
Collaborator Author

szEvEz commented Apr 16, 2024

Hm, you completely removed the documentation on how to use it without helm. Can you re-add this please?

Sure, done!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
szEvEz and others added 2 commits April 16, 2024 09:53
Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com>
Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com>
@rndmh3ro rndmh3ro merged commit 18ab17f into telekom-mms:main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants