Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2313 data grid sort order #2324

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

marcrobertscamao
Copy link
Contributor

@marcrobertscamao marcrobertscamao commented Jun 14, 2024

This fix only resets the sort order when the fields change, which may disable the sorting behaviour or change the field order.

If the data changes and an active sort order is set then this resorts the data accordingly.

Fixes #2313

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 58062bd
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/666c3c5abfcb120008a8dedb
😎 Deploy Preview https://deploy-preview-2324--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcrobertscamao
Copy link
Contributor Author

@acstll is there anything I can do to move this along, I am not sure why the visual tests are failing it looks like an outdated hook needs to be updated in the ci?

Also at which point are updated versions released?

@marcrobertscamao
Copy link
Contributor Author

@maomaoZH @acstll @felix-ico is there anything happening here, we unfortunately require this feature for UAT testing

@acstll
Copy link
Collaborator

acstll commented Jul 3, 2024

I am not sure why the visual tests are failing it looks like an outdated hook needs to be updated in the ci?

correct, I think we can safely ignore them

Also at which point are updated versions released?

currently there's no schedule but I think we can try and define one… I'll talk to @maomaoZH to get this released

@acstll acstll merged commit 3558e4b into telekom:main Jul 3, 2024
11 of 12 checks passed
@marcrobertscamao
Copy link
Contributor Author

@acstll thank you for the quick response and resolution, let me know if there is anything else I can do to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid loses sort on data change
2 participants