Project generators functions need some refactoring #25
Assignees
Labels
Milestone
Comments
alexnm
added
good first issue
ionutpasca
pushed a commit
that referenced
this issue
Mar 28, 2019
ionutpasca
pushed a commit
that referenced
this issue
Mar 28, 2019
ionutpasca
pushed a commit
that referenced
this issue
Mar 28, 2019
ionutpasca
pushed a commit
that referenced
this issue
Mar 28, 2019
ionutpasca
pushed a commit
that referenced
this issue
Mar 29, 2019
ionutpasca
pushed a commit
that referenced
this issue
Mar 29, 2019
ionutpasca
pushed a commit
that referenced
this issue
Mar 29, 2019
ionutpasca
pushed a commit
that referenced
this issue
Mar 29, 2019
ionutpasca
pushed a commit
that referenced
this issue
Mar 29, 2019
alexnm
pushed a commit
that referenced
this issue
Mar 29, 2019
* Refactored react-basic project generator * refactor: Refactored the react-next project generator #25 * refactor: Refactor vue-basic project generator #25 * refactor: Refactored vue-nuxt project generator #25 * refactor: Extracted params in an interface #25 * refactor: Changes made after pull request #25 * refactor: Changed a function name #25 * refactor: Changes after pull request #25 * refactor: Fixed a typo #25
alexnm
pushed a commit
that referenced
this issue
Apr 2, 2019
* Refactored react-basic project generator * refactor: Refactored the react-next project generator #25 * refactor: Refactor vue-basic project generator #25 * refactor: Refactored vue-nuxt project generator #25 * refactor: Extracted params in an interface #25 * refactor: Changes made after pull request #25 * feat(project error handling): adding validator and error handling * test(project valdiator tests): adding test for project validator * refactor(refactor after mr remarks): changes where skipValidation option is sent SkipValidation option is sent from generateComponent options. Adding option to skip validation on generate project. Adding test to check this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a lot of duplication currently in the main functions of the project generators:
src/project-generators/react-basic/index.tssrc/project-generators/react-next/index.tssrc/project-generators/vue-basic/index.tssrc/project-generators/vue-nuxt/index.tsHelper functions can be extracted for creating various types of files (ex: createJSfile, createCSSfile, etc.), or for creating folders (ex: createFolder) or for the dependencies merge then generator functions will be smaller.
React project generators should have priority for now, until #45 is solved, because Vue generators don't have the
globalsimplementation yetThe text was updated successfully, but these errors were encountered: