Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#25 project generators #115

Merged
merged 10 commits into from
Mar 29, 2019
Merged

Conversation

ionutpasca
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #115 into master will increase coverage by 0.4%.
The diff coverage is 93.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #115     +/-   ##
=========================================
+ Coverage   93.92%   94.32%   +0.4%     
=========================================
  Files          47       50      +3     
  Lines        1613     1674     +61     
  Branches      211      229     +18     
=========================================
+ Hits         1515     1579     +64     
+ Misses         86       83      -3     
  Partials       12       12
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️
src/project-generators/react-basic/utils.ts 100% <100%> (ø)
src/project-generators/react-basic/constants.ts 100% <100%> (ø) ⬆️
src/project-generators/react-next/constants.ts 100% <100%> (ø) ⬆️
src/project-generators/vue-basic/utils.ts 100% <100%> (ø)
src/project-generators/vue-nuxt/utils.ts 100% <100%> (ø)
src/project-generators/vue-basic/constants.ts 100% <100%> (ø) ⬆️
src/project-generators/vue-nuxt/constants.ts 100% <100%> (ø) ⬆️
src/shared/constants.ts 100% <100%> (ø) ⬆️
src/project-generators/vue-nuxt/index.ts 91.11% <90.47%> (+4.83%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442f9b4...6f0af17. Read the comment docs.

src/project-generators/react-basic/index.ts Show resolved Hide resolved
src/project-generators/react-basic/index.ts Outdated Show resolved Hide resolved
src/project-generators/react-basic/index.ts Outdated Show resolved Hide resolved
src/shared/utils/project-utils.ts Outdated Show resolved Hide resolved
src/shared/utils/project-utils.ts Outdated Show resolved Hide resolved
src/shared/utils/project-utils.ts Outdated Show resolved Hide resolved
src/typings/generators.d.ts Outdated Show resolved Hide resolved
src/shared/utils/project-utils.ts Outdated Show resolved Hide resolved
@ionutpasca ionutpasca requested a review from alexnm March 29, 2019 14:14
Copy link
Contributor

@alexnm alexnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, just 2-3 small changes I would suggest, but let's talk if you have other ideas there

src/project-generators/react-basic/index.ts Show resolved Hide resolved
src/project-generators/react-basic/index.ts Outdated Show resolved Hide resolved
src/shared/utils/project-utils.ts Outdated Show resolved Hide resolved
@ionutpasca ionutpasca requested a review from alexnm March 29, 2019 17:29
@alexnm alexnm merged commit 4559e44 into master Mar 29, 2019
@alexnm
Copy link
Contributor

alexnm commented Mar 29, 2019

@allcontributors[bot] please add @ovidiuionut94 for code

@allcontributors
Copy link
Contributor

@alexnm

I've put up a pull request to add @ovidiuionut94! 🎉

@alexnm alexnm deleted the refactor/#25-project-generators branch March 30, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants