Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/packages update #13

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Refactor/packages update #13

merged 2 commits into from
Jun 6, 2019

Conversation

xavxyz
Copy link
Contributor

@xavxyz xavxyz commented Jun 5, 2019 •
edited by ionutpasca
Loading

Context

Fixes #10 as version 0.7.0 of generators got published! 🚀

Proposed solution

  • Use individual packages instead of the main big one
  • Manage available plugins with a list (InlineStyles, JSS, StyledJSX, CSSModules) to get in a glance what are the available flavors.
  • Remove package-lock.json as Yarn is used on all TeleportHQ OSS projects

Tests

  • Install new deps, yarn
  • Run the playground yarn dev
  • Select a component featuring styles in its UIDL, like expandable-area
  • Code is generated as expected for React flavors:
    • InlineStyles
    • JSS
    • StyledJSX
    • CSSModules
  • Code is generated as expected for Vue

@vercel
Copy link

vercel bot commented Jun 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://repl-git-refactor-packages-update.teleport-dev.now.sh

@xavxyz xavxyz added the enhancement New feature or request label Jun 5, 2019
@xavxyz xavxyz mentioned this pull request Jun 5, 2019
Merged
4 tasks
alexnm
alexnm approved these changes Jun 5, 2019
View reviewed changes
components/CodeScreen/index.tsx Outdated Show resolved Hide resolved
@alexnm alexnm merged commit bfc404a into master Jun 6, 2019
@alexnm alexnm deleted the refactor/packages-update branch July 1, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexnm alexnm alexnm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate the new versions of generators
2 participants
@xavxyz @alexnm