Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON parse fails while trying to display some ballots. #90

Closed
Tracked by #73
Viterbo opened this issue Sep 19, 2022 · 3 comments · Fixed by #104 or #117
Closed
Tracked by #73

JSON parse fails while trying to display some ballots. #90

Viterbo opened this issue Sep 19, 2022 · 3 comments · Fixed by #104 or #117
Assignees
@Viterbo
Labels
🐛 Bug Something isn't working
Milestone
Enable smooth voting

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Sep 19, 2022 •
edited
Loading

The code assumes all ballots come with a valid JSON string in the 'content' field. However, there are some that come with the text "Telos Amend Proposal" with cause the parser to break, and the popup just gets stuck.

ballots-parse-break
@Viterbo Viterbo mentioned this issue Sep 19, 2022
Closed
15 tasks
@Viterbo Viterbo added the 🐛 Bug Something isn't working label Sep 19, 2022
@Viterbo Viterbo self-assigned this Sep 19, 2022
Viterbo added a commit that referenced this issue Sep 19, 2022
@Viterbo
fix: extraction of pdf or image url with no errors. This commit closes …
3f45a3c 
…#90.
@Viterbo Viterbo mentioned this issue Sep 19, 2022
Closed
@karynemayer karynemayer mentioned this issue Sep 19, 2022
Closed
@Viterbo Viterbo added this to the Enable smooth voting milestone Sep 20, 2022
Viterbo added a commit that referenced this issue Sep 21, 2022
@Viterbo
iframeUrl function fixes issue #90
f29859c
@Viterbo Viterbo mentioned this issue Sep 21, 2022
Merged
donnyquixotic pushed a commit that referenced this issue Sep 21, 2022
@Viterbo @donnyquixotic
iframeUrl function fixes issue #90
0d3501e
@donnyquixotic donnyquixotic mentioned this issue Sep 21, 2022
Merged
@Viterbo
Copy link
Collaborator Author

Viterbo commented Sep 21, 2022

I close this issue because is fixed and merged

@Viterbo Viterbo closed this as completed Sep 21, 2022
@Viterbo
Copy link
Collaborator Author

Viterbo commented Sep 22, 2022

I'm reopening this issue because is not solved.
Somehow I didn't push the try-catch fix that I mention here in the comments, so the problems still remain.

@Viterbo Viterbo reopened this Sep 22, 2022
@Viterbo Viterbo mentioned this issue Sep 22, 2022
Merged
@Viterbo Viterbo linked a pull request Sep 22, 2022 that will close this issue
avoid crashes due to null objects property access attempts #117
Merged
@Viterbo
Copy link
Collaborator Author

Viterbo commented Sep 22, 2022

I close this issue is fixed and merged

@Viterbo Viterbo closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viterbo Viterbo

Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
Enable smooth voting
1 participant
@Viterbo