Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid crashes due to null objects property access attempts #117

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Sep 22, 2022

Description

just avoid crashes by asserting the objects are not null and surrounding with try-catch some sensitive code.

Fixes #90

@Viterbo Viterbo linked an issue Sep 22, 2022 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for telos-app-native-mainnet ready!

Name Link
🔨 Latest commit 96754b0
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-mainnet/deploys/632ce1f787e79f0008b5237a
😎 Deploy Preview https://deploy-preview-117--telos-app-native-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for telos-app-native-testnet ready!

Name Link
🔨 Latest commit 96754b0
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-testnet/deploys/632ce1f797a05b00092c2ca4
😎 Deploy Preview https://deploy-preview-117--telos-app-native-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Viterbo Viterbo changed the base branch from master to develop September 22, 2022 22:30
@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 168bbd0
Status: ✅  Deploy successful!
Preview URL: https://3129c0d8.app-telos-native.pages.dev
Branch Preview URL: https://90-try-catch-json-parsing.app-telos-native.pages.dev

View logs

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for telos-app-native-staging ready!

Name Link
🔨 Latest commit 168bbd0
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-staging/deploys/632ce2cd6a11760009db0b65
😎 Deploy Preview https://deploy-preview-117--telos-app-native-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@karynemayer karynemayer merged commit e410cd2 into develop Sep 22, 2022
@karynemayer karynemayer deleted the 90-try-catch-json-parsing branch September 22, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON parse fails while trying to display some ballots.
3 participants