Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closes #284 ] Adds max options logic #285

Merged
merged 2 commits into from
May 20, 2023
Merged

[Closes #284 ] Adds max options logic #285

merged 2 commits into from
May 20, 2023

Conversation

karynemayer
Copy link
Contributor

@karynemayer karynemayer commented May 10, 2023

Fixes #284

Description

Changes were made in order for the behavior to be the following:

  • User is notified when multiple selection is available with a message including min and max number of options
  • If user selects more than the max, we unselect the first selected item
  • Changed scrolling to be enables at the popup level instead of the number of options so the user can see the item being unselected when he exceeds the maximum allowed
  • Vote button and selections are disabled when not signed in.

Test scenarios

use /trails/ballot/myproposal/1683755639862 for testing

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file
  • I have created a new issue with the required translations for the currently supported languages
  • I have added appropriate test coverage

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for telos-app-native-staging ready!

Name Link
🔨 Latest commit c69d1cb
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-staging/deploys/6466a4a7b7f6c700088efa22
😎 Deploy Preview https://deploy-preview-285--telos-app-native-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@karynemayer karynemayer requested a review from pmjanus May 10, 2023 23:57
@karynemayer karynemayer marked this pull request as draft May 11, 2023 17:03
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c69d1cb
Status: ✅  Deploy successful!
Preview URL: https://b90cd615.app-telos-native.pages.dev
Branch Preview URL: https://max-options-warn.app-telos-native.pages.dev

View logs

@karynemayer karynemayer marked this pull request as ready for review May 17, 2023 23:08
@karynemayer karynemayer linked an issue May 18, 2023 that may be closed by this pull request
@pmjanus pmjanus merged commit 0cb6cad into develop May 20, 2023
@pmjanus pmjanus deleted the max-options-warn branch May 20, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App-Telos-Native Allows Voting Beyond Max Limit Without Warning
3 participants