Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow any user to execute an approved proposal #829

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

donnyquixotic
Copy link
Contributor

@donnyquixotic donnyquixotic commented Feb 8, 2024

Description

Allow any user to execute an approved proposal

Test scenarios

Execute an approved proposal with an account that was not required to approve

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages

@donnyquixotic donnyquixotic self-assigned this Feb 8, 2024
Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 4eeb4a3
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/65c42ad7de22810009ee4c74
😎 Deploy Preview https://deploy-preview-829--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit 4eeb4a3
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/65c42ad7f89e790007e6207c
😎 Deploy Preview https://deploy-preview-829--open-block-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Feb 8, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4eeb4a3
Status: ✅  Deploy successful!
Preview URL: https://48b567b6.open-block-explorer.pages.dev
Branch Preview URL: https://fix-any-user-approve-proposa.open-block-explorer.pages.dev

View logs

@donnyquixotic donnyquixotic merged commit 99a95c9 into master Feb 8, 2024
10 checks passed
@donnyquixotic donnyquixotic deleted the fix/any-user-approve-proposal branch February 8, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant