Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native TLOS OFT #67

Merged
merged 29 commits into from
Jun 10, 2024
Merged

Native TLOS OFT #67

merged 29 commits into from
Jun 10, 2024

Conversation

donnyquixotic
Copy link
Contributor

@donnyquixotic donnyquixotic commented Feb 1, 2024

Description

Adds native TLOS OFT support. See #57.
Contract Repo: https://github.com/telosnetwork/TelosOFT

Test scenarios

transfer TLOS from Telos EVM:

  • Ethereum
  • BSC
  • Polygon
  • Arbitrum
  • Avalanche

transfer TLOS from Ethereum:

  • Telos EVM
  • BSC
  • Polygon
  • Arbitrum
  • Avalanche

transfer TLOS from BSC:

  • Telos EVM
  • Ethereum
  • Polygon
  • Arbitrum
  • Avalanche

transfer TLOS from Polygon:

  • Telos EVM
  • Ethereum
  • BSC
  • Arbitrum
  • Avalanche

transfer TLOS from Arbitrum:

  • Telos EVM
  • Ethereum
  • BSC
  • Polgyon
  • Avalanche

transfer TLOS from Avalanche:

  • Telos EVM
  • Ethereum
  • BSC
  • Polgyon
  • Arbitrum

Transfer OFT Contract Ownership:

  • Telos
  • Ethereum
  • BSC
  • Polygon
  • Arbitrum
  • Avalanche

Transfer Proxy Contract Ownership & Admin:

  • Telos
  • Ethereum
  • BSC
  • Polygon
  • Arbitrum
  • Avalanche

other:

  • added gas on destination for TLOS OFT transfers
  • swapping networks by clicking 'switch' arrow button updates output and immediately executable
  • transaction progress and links should display consistent with other transactions
  • wrapped asset bridge transfers should execute normally
  • other OFT token transfers should execute normally
  • TLOS price
  • token order

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have tested for mobile functionality and responsiveness

@donnyquixotic donnyquixotic self-assigned this Feb 1, 2024
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for telos-bridge ready!

Name Link
🔨 Latest commit 525177a
🔍 Latest deploy log https://app.netlify.com/sites/telos-bridge/deploys/6666fa5539834f0009893ba0
😎 Deploy Preview https://deploy-preview-67--telos-bridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@donnyquixotic donnyquixotic marked this pull request as ready for review February 2, 2024 00:28
}
/* eslint-disable-next-line react-hooks/exhaustive-deps */
}, [address, form.srcChainId, srcChainId, isReady]);

/*** set max balance as default token ***/
Copy link
Contributor Author

@donnyquixotic donnyquixotic Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this for future use

Copy link
Contributor

@ezra-sg ezra-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to actually test functionality but great job with the code part! does not seem like it was easy to figure out, very nice going

src/features/bridge/stores/bridgeStore.tsx Outdated Show resolved Hide resolved
src/tokenList.ts Outdated Show resolved Hide resolved
src/features/core/ui/CurrencyIcon.tsx Outdated Show resolved Hide resolved
@ezra-sg

This comment was marked as resolved.

@donnyquixotic

This comment was marked as resolved.

ezra-sg
ezra-sg previously approved these changes Feb 6, 2024
Copy link
Contributor

@ezra-sg ezra-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tomtomcrypto
Copy link
Contributor

tomtomcrypto commented May 13, 2024

Resetting test scenarios following new version of contracts

@tomtomcrypto tomtomcrypto self-assigned this May 14, 2024
@tomtomcrypto tomtomcrypto added the 🎯 Feature New feature label May 14, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for sparkly-dasik-ad5e27 ready!

Name Link
🔨 Latest commit 525177a
🔍 Latest deploy log https://app.netlify.com/sites/sparkly-dasik-ad5e27/deploys/6666fa55bbd886000990d8fc
😎 Deploy Preview https://deploy-preview-67--sparkly-dasik-ad5e27.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomtomcrypto tomtomcrypto requested a review from ezra-sg June 8, 2024 22:50
@tomtomcrypto tomtomcrypto marked this pull request as ready for review June 10, 2024 13:05
@tomtomcrypto tomtomcrypto requested review from rozzaswap and a team June 10, 2024 13:06
@tomtomcrypto tomtomcrypto merged commit 1104699 into master Jun 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 Feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants