Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types improvements #887

Merged
merged 10 commits into from
Jun 10, 2023
Merged

Types improvements #887

merged 10 commits into from
Jun 10, 2023

Conversation

WaffleLapkin
Copy link
Contributor

See the changelog/individual commits for complete set of changes, but TL;DR:

  • Add ThreadId
  • Use u32 and u8 instead of i32 where applicable
  • Use Seconds and MessageId more

@WaffleLapkin WaffleLapkin added S-waiting-on-review Status: Awaiting review from the assignee C-core crate: teloxide-core breaking change labels Jun 5, 2023
Hirrolot
Hirrolot approved these changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@Hirrolot Hirrolot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Hirrolot Hirrolot added this pull request to the merge queue Jun 10, 2023
Merged via the queue into master with commit 326c851 Jun 10, 2023
@Hirrolot Hirrolot deleted the use_message_id_type_more branch June 10, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hirrolot Hirrolot Hirrolot approved these changes

Assignees
No one assigned
Labels
breaking change C-core crate: teloxide-core S-waiting-on-review Status: Awaiting review from the assignee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaffleLapkin @Hirrolot