Fixed incorrect converting meter rate/burstsize from packets to kilobits #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksv
commented
Aug 4, 2019
| config.getSystemMeterBurstSizeInPackets(), actionList); | ||
| } | ||
|
|
||
| private OFInstructionMeter installOfReinstallMeter(IOFSwitch sw, long meterId, long rateInPackets, |
There was a problem hiding this comment.
new method was added because it will be used in connected devices patch
rtretyak
approved these changes
Aug 5, 2019
dpoltavets
approved these changes
Aug 5, 2019
We converted packets to kilobytes, not to kilobits. It causes incorrect meters on Centec and E switches
niksv
changed the title
timofei-durakov
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We converted packets to kilobytes, not to kilobits.
It causes incorrect meters on Centec and E switches