fix(community-side-navigation): fix uglified js issue with onclick

telus · Jan 10, 2019 · c32fb4c · c32fb4c
1 parent 81e4493
commit c32fb4c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/SideNavigation/SideNavigation.jsx b/packages/SideNavigation/SideNavigation.jsx
@@ -153,7 +153,7 @@ class SideNavigation extends Component {
               const id = `TDS-SideNavigation-${index}`
               if (child.type.name === 'SubMenu') {
                 options = {
-                  onClick: this.toggleOpen,
+                  onSubMenuClick: this.toggleOpen,
                   isOpen: this.checkAccordion(id),
                   active: child.props.active,
                   id,

diff --git a/packages/SideNavigation/SubMenu/SubMenu.jsx b/packages/SideNavigation/SubMenu/SubMenu.jsx
@@ -15,7 +15,7 @@ import styles from './SubMenu.scss'
  *
  * _This component can only be accessed as a name-spaced component: `SideNavigation.SubMenu`._
  */
-const SubMenu = ({ children, label, onClick, id, isOpen, active }) => {
+const SubMenu = ({ children, label, onSubMenuClick, id, isOpen, active }) => {
   const options = {
     subMenuLink: true,
   }
@@ -24,7 +24,7 @@ const SubMenu = ({ children, label, onClick, id, isOpen, active }) => {
     <div className={styles.mainDiv}>
       <button
         onClick={() => {
-          onClick(id)
+          onSubMenuClick(id)
         }}
         className={active ? styles.active : styles.buttonDefault}
       >
@@ -62,7 +62,7 @@ SubMenu.propTypes = {
    *
    * @ignore
    */
-  onClick: PropTypes.func,
+  onSubMenuClick: PropTypes.func,
   /**
    * ID of the SubMenu, must be unique when using multiple SubMenus within the same SideNavigation component.
    * @ignore
@@ -81,7 +81,7 @@ SubMenu.propTypes = {
 }
 
 SubMenu.defaultProps = {
-  onClick: undefined,
+  onSubMenuClick: undefined,
   isOpen: false,
   active: false,
   children: undefined,

diff --git a/packages/SideNavigation/__tests__/__snapshots__/SideNavigation.spec.jsx.snap b/packages/SideNavigation/__tests__/__snapshots__/SideNavigation.spec.jsx.snap
@@ -177,6 +177,7 @@ exports[`SideNavigation renders 1`] = `
             isOpen={false}
             label="Threefdsfdsfds"
             onClick={[Function]}
+            onSubMenuClick={[Function]}
           >
             <div
               className="mainDiv"
@@ -316,6 +317,7 @@ exports[`SideNavigation renders without vertical spacing 1`] = `
             isOpen={true}
             label="Threefdsfdsfds"
             onClick={[Function]}
+            onSubMenuClick={[Function]}
           >
             <div
               className="mainDiv"