Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDS Testimonial without drop-shadow #192

Closed
karlasamantha opened this issue Mar 7, 2019 · 17 comments
Closed

TDS Testimonial without drop-shadow #192

karlasamantha opened this issue Mar 7, 2019 · 17 comments
Assignees
Labels
priority: low low priority item status: completed 💥 issue completed type: feature new feature or enhancement of existing component

Comments

@karlasamantha
Copy link

Question statement

  • As a developer , I would like to ask, if there's a possibility to extend TDS Testimonial component to have the flexibility of not having drop-shadow and different font sizes

Recommendation

  • Add an option of removing drop-shadow from the component
  • Possibility of having smaller font size

Design intent

screen shot 2019-03-07 at 9 50 34 am

Acceptance criteria

This section is intentionally left blank. See story writing process.

User stories

(This section is intentionally left blank. User stories and acceptance criteria go here.)

Example:

Scenario: Displaying the component

Given text is provided
Then the text is displayed as a child
And the text size matches core-text medium

Out of scope

(This section is intentionally left blank. Features or items that were deliberately left out of scope during design intent or may be mistaken as within scope are noted here. Link to related issues if possible.)

Meta

  • Include component name and version: @tds/community-testimonial 1.0.3
  • Willing to design solution: No
  • Willing to develop solution: Yes
  • Has workaround: No
  • Which teams/applications do you think would use this improvement? Brand Experience team
  • High impact: No
@invalidred
Copy link
Contributor

@agorovyi thinks that from Dev perspective this should not be too hard to accomplish, however we need design approval.

@invalidred invalidred added status: DPA design review needed A feature or request that requires DPA design review priority: low low priority item labels Mar 8, 2019
@karlasamantha
Copy link
Author

my team has consulted with @gkychow and he approved this design

@theetrain
Copy link
Contributor

Hi @karlasamantha,

This was reviewed by the DPA and we agree the community testimonial component can be enhanced to completely remove the card surrounding the component. If anyone wants a testimonial within a card, they can do so manually.

Designer comments: go ahead with removing the card
Developer comments: this should be a breaking change v1.03 -> v2.0.0

We need a designer and developer pair to work on this.

When a card is needed

Before

<Testimonial
  testimonial={`“My office is where ever my customers are. TELUS helps me stay connected whether I'm making a sale or doing payroll.”`}
  title="Dave Smith, Foreman"
  additionalInfo="Pinnacle Reforestation"
/>

After

<Card>
  <Testimonial
    testimonial={`“My office is where ever my customers are. TELUS helps me stay connected whether I'm making a sale or doing payroll.”`}
    title="Dave Smith, Foreman"
    additionalInfo="Pinnacle Reforestation"
  />
</Card>

@theetrain theetrain removed the status: DPA design review needed A feature or request that requires DPA design review label Mar 11, 2019
@theetrain theetrain added this to To do in Community Backlog via automation Mar 11, 2019
@theetrain theetrain moved this from To do to Design queue in Community Backlog Mar 11, 2019
@karlasamantha karlasamantha self-assigned this Mar 22, 2019
@varunj90
Copy link
Contributor

hey @karlasamantha can anyone on your team make changes based on @theetrain comments: has to be designer/developer pair.

@karlasamantha
Copy link
Author

hey @varunj90 I can work on the dev part, unfortunately my team does not have a designer. can I try pairing with Gary if he's available?

@varunj90
Copy link
Contributor

varunj90 commented Apr 5, 2019

yes @karlasamantha please connect with @gkychow if he has cycles, otherwise the core team designers can assist, let us know :)

karlasamantha pushed a commit that referenced this issue May 8, 2019
BREAKING CHANGE: removes card from community-testimonial component

#192
@karlasamantha
Copy link
Author

See #215

@varunj90 varunj90 moved this from Design queue to In development (code and design) in Community Backlog May 14, 2019
@varunj90
Copy link
Contributor

hey @karlasamantha thanks for making a PR, in order for the code to be approved, can you send us the updated designs for this PR.

all components need to be consistent both in design and code. let us know.

@varunj90 varunj90 added type: feature new feature or enhancement of existing component status: design needed 🎨 labels May 14, 2019
@varunj90 varunj90 changed the title question: TDS Testimonial without drop-shadow, is it possible? TDS Testimonial without drop-shadow May 14, 2019
@karlasamantha
Copy link
Author

Hey @varunj90 does this one work? let me know.
Screen Shot 2019-05-14 at 1 07 18 PM

@varunj90
Copy link
Contributor

can you share the design file link on sketch/invision?

it will have to be reviewed by another designer as well. exactly how we are doing in code

@karlasamantha
Copy link
Author

@varunj90 ah gotcha! I'll ask Gary to send them over. Thanks!

@donnavitan
Copy link
Contributor

Hey hey y'all! After speaking with CX and CPP (Site Builder team), the consensus is to build the TDS community component and the Site Builder component in the same manner. This will remove any confusion and disparity when working with both, as a designer, developer, and content practitioner.

I'll be able to help you with the artwork for Sketch DSM library.

Adding the screenshot from our discussion to confirm that the component itself does not contain padding; the parent container will have that if you so choose to use a card or not.

Screen Shot 2019-05-16 at 1 52 18 PM

Thank you @karlasamantha! Let's rock and roll!

@donnavitan
Copy link
Contributor

Need to confirm with CX that the testimonial should be set at 20px font size as per design in TDS component. Live example shows it displaying at 16px font size (as per Site Builder component). We want to be as consistent and have our components be 1:1 for TDS and Site Builder components where possible.

Design thus far:
image

Testimonial in the wild at 16px font-size: https://www.telus.com/en/about/careers (middle of page)
Testimonial in the wild at 20px font-size: https://www.telus.com/en/bc/business (bottom of page)

@donnavitan
Copy link
Contributor

@karlasamantha confirmed with CX that testimonials should align with 20px font-size for the body text. Please update both TDS community component and Site Builder component accordingly, where possible.

@karlasamantha
Copy link
Author

karlasamantha commented May 22, 2019

@donnavitan okay, the Site Builder block is only a wrapper for TDS testimonial component, so I'll update the component and as soon as the update is released it'll update Site Builder.

theetrain pushed a commit that referenced this issue May 22, 2019
BREAKING CHANGE: removes card from community-testimonial component

#192
marcod1419 pushed a commit that referenced this issue May 22, 2019
BREAKING CHANGE: removes card from community-testimonial component

#192
@marcod1419
Copy link
Contributor

This has been released in testimonial 2.0.0! https://github.com/telus/tds-community/releases/tag/%40tds%2Fcommunity-testimonial%402.0.0

@varunj90 varunj90 added the status: completed 💥 issue completed label May 23, 2019
@theetrain
Copy link
Contributor

This has been released in DSM 1.0.19
https://tds.telus.com/community/index.html#testimonial

@theetrain theetrain moved this from In development (code and design) to Released in Community Backlog May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low low priority item status: completed 💥 issue completed type: feature new feature or enhancement of existing component
Projects
Community Backlog
  
Released
Development

No branches or pull requests

7 participants