-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle icon #29
Comments
While developing this component, will keep it stateless for maximum flexibility, as per issue: telus/tds-core#736 If a stateful version is required in the future, it should be relatively simple to wrap the stateless version and provide internal state management in that way. |
@DanGenuardi Are there component level designs illustrating the disabled state (as in not clickable) and / or error state? I'm considering this component to basically be a form checkbox, in Is that part of the current design(s) for this, or a future addition? |
@jesdavpet there isn't a disabled state where it isn't clickable with the toggle in the design. But we have a design where the data access is blocked. Please view this invision link for reference. https://telus.invisionapp.com/d/main#/console/13507983/288289626/preview |
OK, thanks for the follow up @DanGenuardi So when the customer is not allowed to click the toggle, currently you're just conditionally displaying a blocked icon & message instead of the toggle ... so, I'll just leave that part out. Is there an error state, with an error message in the designs, like this example ("Mobility" checkbox has a pink box with error text above it, pictured below): |
@jesdavpet for the toggle? no we don't. |
Cool, thanks for clarifying @DanGenuardi ! I'm just leaving that out for now then ... can be added later if/when there's a need. |
This component has been released: @tds/community-toggle-switch@1.0.0 |
This component is now available for everyone on DSM -> TDS Community -> Components Coded -> Toggle @theetrain |
assignees have been added on closed issue to reflect power level (points) on community heroes board (coming soon!) |
Problem Statement
Recommendation
Designs
Enabled: https://telus.invisionapp.com/d/main#/console/13507983/281885578/preview
Disabled: https://telus.invisionapp.com/d/main#/console/13507983/283301249/preview
Meta
The text was updated successfully, but these errors were encountered: