Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle icon #29

Closed
DanGenuardi opened this issue Jun 6, 2018 · 9 comments
Closed

Toggle icon #29

DanGenuardi opened this issue Jun 6, 2018 · 9 comments
Assignees
Labels
priority: high high priority item status: completed 💥 issue completed type: new component 🎁 New component

Comments

@DanGenuardi
Copy link

Problem Statement

  • We created a new data toggle for the usage page to enable and disable data within their plan.

Recommendation

  • add data toggle icon into the TDS library for future use for any team.

Designs

Meta

  • Willing to design solution: Yes/No
  • Willing to develop solution: Yes/No
  • Has workaround: Yes/No
  • Do any similar components already exist: Yes/No
  • Does this pattern exist already but isn’t a community component? (include url)
  • Which teams/applications do you think would use this improvement?
  • High impact: Yes/No
@varunj90 varunj90 added the priority: high high priority item label Jun 8, 2018
@varunj90 varunj90 added type: new component 🎁 New component status: DPA design approved approved design by the DPA that can be picked for development labels Jun 12, 2018
@varunj90 varunj90 changed the title Data Toggle icon Toggle icon Jun 18, 2018
@jesdavpet jesdavpet self-assigned this Aug 3, 2018
@jesdavpet jesdavpet added the status: in development 💻 feature or request that is in development label Aug 3, 2018
@jesdavpet
Copy link
Contributor

While developing this component, will keep it stateless for maximum flexibility, as per issue: telus/tds-core#736

If a stateful version is required in the future, it should be relatively simple to wrap the stateless version and provide internal state management in that way.

@jesdavpet
Copy link
Contributor

jesdavpet commented Sep 19, 2018

@DanGenuardi Are there component level designs illustrating the disabled state (as in not clickable) and / or error state?

I'm considering this component to basically be a form checkbox, in @tds/core-checkbox the concept of an error message and disabled state are encapsulated with the checkbox component.

Is that part of the current design(s) for this, or a future addition?
CC: @lucylist @Berjesty

@DanGenuardi
Copy link
Author

@jesdavpet there isn't a disabled state where it isn't clickable with the toggle in the design. But we have a design where the data access is blocked. Please view this invision link for reference. https://telus.invisionapp.com/d/main#/console/13507983/288289626/preview

@jesdavpet
Copy link
Contributor

OK, thanks for the follow up @DanGenuardi

So when the customer is not allowed to click the toggle, currently you're just conditionally displaying a blocked icon & message instead of the toggle ... so, I'll just leave that part out.

Is there an error state, with an error message in the designs, like this example ("Mobility" checkbox has a pink box with error text above it, pictured below):
screen shot 2018-09-19 at 3 43 41 pm

@DanGenuardi
Copy link
Author

@jesdavpet for the toggle? no we don't.

@jesdavpet
Copy link
Contributor

for the toggle? no we don't.

Cool, thanks for clarifying @DanGenuardi ! I'm just leaving that out for now then ... can be added later if/when there's a need.

@theetrain theetrain self-assigned this Oct 2, 2018
@theetrain
Copy link
Contributor

This component has been released: @tds/community-toggle-switch@1.0.0

@theetrain theetrain removed status: DPA design approved approved design by the DPA that can be picked for development status: in development 💻 feature or request that is in development labels Oct 11, 2018
@Berjesty
Copy link

This component is now available for everyone on DSM -> TDS Community -> Components Coded -> Toggle @theetrain

@varunj90
Copy link
Contributor

assignees have been added on closed issue to reflect power level (points) on community heroes board (coming soon!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high high priority item status: completed 💥 issue completed type: new component 🎁 New component
Projects
None yet
Development

No branches or pull requests

5 participants