[COR-221] Check for terminating namespace on deletion #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstanton
requested review from
ryw,
ChuckHend and
sjmiller609
as code owners
ChuckHend
approved these changes
Feb 14, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
added a commit
that referenced
this pull request
Dec 5, 2023
* WIP: moving ingress route tcp into operator * wip: switching logic to just check for all the existing mathers * reconcile logic for ingress route tcp looks right * Resolved compiler errors in operator * clippy + fmt * Remove code in conductor * clippy + fmt * Add to reconcile loop * fmt * handle env var * Adjust justfile * Test on k8s 1.26, also helps with flake detection * Add Traefik to justfile * Use justfile in CI * Tidy logs * tidy ci * add makedeb * install just with gha * install kind * tidy comment * Add new tests * fmt * Install helm in CI * Add another test * increase timeout * Add env configuration to helm chart * fmt * Run on larger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in which namespaces are stuck in terminating state. If
coredbdeletion is triggered due to namespace deletion, we skip publishing a delete event. This allows for successful cleanup of thecoredbresource and its namespace.Related to: https://linear.app/coredb/issue/COR-221/bug-namespaces-stuck-terminating-on-coredb-deletion