Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pg metrics #12

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Pg metrics #12

merged 4 commits into from
Dec 16, 2022

Conversation

ChuckHend
Copy link
Collaborator

@ChuckHend ChuckHend commented Dec 16, 2022

Sets pattern for exporting pg server metrics. two bugs currently exist:

  1. background thread doesn't get killed when pgx stops
  2. the query result seems to have some strange type casting. e.g. expecting a value ~100 and getting some very large int like 4974814424

@ChuckHend ChuckHend marked this pull request as ready for review December 16, 2022 04:33
Co-authored-by: Ian Stanton <ian@coredb.io>
@ianstanton ianstanton self-requested a review December 16, 2022 13:35
@ChuckHend ChuckHend merged commit a2317d2 into main Dec 16, 2022
@ChuckHend ChuckHend deleted the pg_metrics branch December 16, 2022 13:44
ianstanton added a commit to ianstanton/coredb that referenced this pull request Mar 23, 2023
sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
sjmiller609 pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants