[COR-205] Add resources to CoreDB spec
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstanton
requested review from
ryw,
ChuckHend and
sjmiller609
as code owners
|
|
ianstanton
commented
Feb 17, 2023
| type: object | ||
| requests: | ||
| additionalProperties: | ||
| description: |- |
There was a problem hiding this comment.
These descriptions can cause unnecessary bloat in our CRD. Go's controller-gen has a maxDescLen flag that you can set to 0 to disable these descriptions. There doesn't seem to be an equivalent in kube-derive at the moment.
It's fine to include them at the moment, but wanted to call this out in case we need to trim things down in the future.
ianstanton
commented
Feb 17, 2023
Comment on lines
+9
to
+15
| let limits: BTreeMap<String, Quantity> = BTreeMap::from([ | ||
| ("cpu".to_owned(), Quantity("2".to_string())), | ||
| ("memory".to_owned(), Quantity("2Gi".to_string())), | ||
| ]); | ||
| let requests: BTreeMap<String, Quantity> = BTreeMap::from([ | ||
| ("cpu".to_owned(), Quantity("500m".to_string())), | ||
| ("memory".to_owned(), Quantity("512Mi".to_string())), |
There was a problem hiding this comment.
@sjmiller609 let me know your thoughts on these default values
ianstanton
changed the title
resources to CoreDB specresources to CoreDB spec
ChuckHend
approved these changes
Feb 17, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
resourcesspec value. Use this value to set resource values on postgres container. Also add default values.