-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COR-205] Add resources
to CoreDB spec
#122
Conversation
|
type: object | ||
requests: | ||
additionalProperties: | ||
description: |- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These descriptions can cause unnecessary bloat in our CRD. Go's controller-gen
has a maxDescLen
flag that you can set to 0
to disable these descriptions. There doesn't seem to be an equivalent in kube-derive
at the moment.
It's fine to include them at the moment, but wanted to call this out in case we need to trim things down in the future.
let limits: BTreeMap<String, Quantity> = BTreeMap::from([ | ||
("cpu".to_owned(), Quantity("2".to_string())), | ||
("memory".to_owned(), Quantity("2Gi".to_string())), | ||
]); | ||
let requests: BTreeMap<String, Quantity> = BTreeMap::from([ | ||
("cpu".to_owned(), Quantity("500m".to_string())), | ||
("memory".to_owned(), Quantity("512Mi".to_string())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjmiller609 let me know your thoughts on these default values
resources
to CoreDB specresources
to CoreDB spec
Add
resources
spec value. Use this value to set resource values on postgres container. Also add default values.