Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of configuration values from the tembo.toml file #471

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

nhudson
Copy link
Collaborator

@nhudson nhudson commented Jan 6, 2024

This change will add configuration validation against the temboclient for the following items. The validation will fail if the client cannot validate the values.

  • environment
  • cpu
  • memory
  • replicas
  • storage
  • stack types

Added tests using a crate called rstest that allows you to easily add macros for fixture based tests. If someone would rather me write all the test scenarios out instead I can, just comment and let me know.

Copy link
Collaborator

@shahadarsh shahadarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for doing this. The tests are failing because it says CPU value is invalid for one of the tests but I think its a valid value. I can take a look at it later. I might have to generate the rust client again with latest values.

@nhudson nhudson merged commit 5a2196a into main Jan 7, 2024
8 checks passed
@nhudson nhudson deleted the nhudson/add_config_validation branch January 7, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants