Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to actions/checkout@v4 #510

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Upgrade to actions/checkout@v4 #510

merged 1 commit into from
Feb 23, 2024

Conversation

theory
Copy link
Contributor

@theory theory commented Jan 25, 2024

No description provided.

@nhudson
Copy link
Collaborator

nhudson commented Jan 25, 2024

This will most likely break the jobs. I've seen v4 not work at all.

@theory
Copy link
Contributor Author

theory commented Jan 25, 2024

Huh. Has worked like a champ for me. v3 is deprecated (nodjs is too old).

@theory
Copy link
Contributor Author

theory commented Jan 26, 2024

@nhudson I reverted the changes in 7bea6cb to see what would happen. Exactly the same tests fail as with the changes, in 9932612. I think perhaps something else needs fixing.

@theory theory force-pushed the checkout-v4 branch 2 times, most recently from 9e79e73 to f228ee4 Compare February 23, 2024 18:59
Replace actions/checkout@v3 with @v4; the former is deprecated and
issues warnings for an out-of-date version of Node JS.

Replace actions-rs/toolchain with dtolnay/rust-toolchain, as the former
has had no changes in 4 years, uses the deprecated `set-output`
function, and was archived in October. Follow the findings of
RustCrypto/actions#17.
@theory theory merged commit e088c90 into main Feb 23, 2024
10 checks passed
@theory theory deleted the checkout-v4 branch February 23, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants