Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moves app_services related code to tembo-stacks crate from control plane so it can be used at other places #529

Merged
merged 3 commits into from
Feb 6, 2024
Merged

moves app_services related code to tembo-stacks crate from control plane so it can be used at other places #529

merged 3 commits into from
Feb 6, 2024

Conversation

shahadarsh
Copy link
Collaborator

@shahadarsh shahadarsh commented Feb 6, 2024 •
edited
Loading

  • Moves apps folder from control-plane to tembo-stacks crate so that tembo-cli and in future other places can use this crate instead of repeating the logic
  • In future, we can also move the common logic that tembo-operator has into this crate.

Related PR: https://github.com/tembo-io/control-plane/pull/509

@shahadarsh shahadarsh marked this pull request as ready for review February 6, 2024 20:15
@shahadarsh shahadarsh marked this pull request as draft February 6, 2024 20:15
@shahadarsh shahadarsh marked this pull request as ready for review February 6, 2024 20:29
ChuckHend
ChuckHend approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@ChuckHend ChuckHend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shahadarsh shahadarsh merged commit ea104f9 into main Feb 6, 2024
7 checks passed
@shahadarsh shahadarsh deleted the tembo-stacks branch February 6, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHend ChuckHend ChuckHend approved these changes

@vrmiguel vrmiguel vrmiguel approved these changes

@DarrenBaldwin07 DarrenBaldwin07 DarrenBaldwin07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahadarsh @ChuckHend @vrmiguel @DarrenBaldwin07