run backup before setting up replica #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhudson
force-pushed
the
nhudson/PLAT-117
branch
from
e5031f5
to
e993dae
Compare
nhudson
requested review from
sjmiller609,
ianstanton and
ChuckHend
as code owners
nhudson
commented
Mar 26, 2024
| @@ -4166,7 +4166,8 @@ CREATE EVENT TRIGGER pgrst_watch | |||
| // Wait for Postgres to restart | |||
| { | |||
| let started = Utc::now(); | |||
| let max_wait_time = chrono::Duration::seconds(TIMEOUT_SECONDS_POD_READY as _); | |||
| let max_wait_time = | |||
| chrono::TimeDelta::try_seconds(TIMEOUT_SECONDS_POD_READY as _).unwrap(); | |||
There was a problem hiding this comment.
Updating deprecated method https://docs.rs/chrono/latest/chrono/type.Duration.html#method.seconds
nhudson
commented
Mar 26, 2024
| @@ -4220,7 +4221,7 @@ CREATE EVENT TRIGGER pgrst_watch | |||
| async fn functional_test_status_configs() { | |||
| async fn runtime_cfg(coredbs: &Api<CoreDB>, name: &str) -> Option<Vec<PgConfig>> { | |||
| let started_waiting = Utc::now(); | |||
| let max_wait_time = chrono::Duration::seconds(45); | |||
| let max_wait_time = chrono::TimeDelta::try_seconds(45).unwrap(); | |||
There was a problem hiding this comment.
Updating deprecated method https://docs.rs/chrono/latest/chrono/type.Duration.html#method.seconds
sjmiller609
approved these changes
Mar 27, 2024
ianstanton
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since enabling snapshots with CNPG, we need a way to bring a potential new replica inline with the primary instance. Currently CNPG states that you must take a backup before bringing a new replica online.
We have opened an issue with CNPG in hopes to build a better solution to this problem. cloudnative-pg/cloudnative-pg#4125
Currently the logic works like this
if increasing replicas (1->2)
pendingorrunningfixes: PLAT-117